After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729875 - gio: cleanup gdbusmessage.c file
gio: cleanup gdbusmessage.c file
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other All
: Normal minor
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-05-09 13:18 UTC by Lukasz Skalski
Modified: 2014-05-10 02:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] gio: cleanup gdbusmessage.c file (16.55 KB, patch)
2014-05-09 13:20 UTC, Lukasz Skalski 		accepted-commit_now Details | Review

Description Lukasz Skalski 2014-05-09 13:18:15 UTC 
cleanup gdbusmessage.c file:

1) removed passing GError to ensure_input_padding() function - it was necessary before commit 3e5214c15c2a19b64d74e7142b6cd0d520dddf04 when we used GData*Streams and GMemoryInputStream with g_seekable_seek() - now it's useless,

2) removed checking return value of ensure_input_padding() function - in previous implementation (like above) g_seekable_seek() could return FALSE - now it's always TRUE,

3) removed passing GError to g_memory_buffer_read_*() functions and checking return value - it also has been inherited after old implementation with g_data_input_stream_read_*() functions - now it's also useless

4) cleaned up code formatting,
Comment 1 Lukasz Skalski 2014-05-09 13:20:12 UTC 
Created attachment 276244 [details] [review]
[PATCH] gio: cleanup gdbusmessage.c file
Comment 2 Allison Karlitskaya (desrt) 2014-05-09 13:26:38 UTC 
Review of attachment 276244 [details] [review]:

Looks pretty harmless, so please commit.

Ideally, in the future, try to keep the whitespace fixes to "pure whitespace" patches, but please don't waste your time cleaning that up for this case.
Comment 3 Lukasz Skalski 2014-05-09 13:49:00 UTC 
(In reply to comment #2)
> Review of attachment 276244 [details] [review]:
> 
> Looks pretty harmless, so please commit.
> 

But how? I don't have enough privileges to commit it :)

> Ideally, in the future, try to keep the whitespace fixes to "pure whitespace"
> patches, but please don't waste your time cleaning that up for this case.
Comment 4 Allison Karlitskaya (desrt) 2014-05-09 14:35:58 UTC 
Sorry.  Forgot.  :)