After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729862 - Add support for NOT NULL constraint on columns
Add support for NOT NULL constraint on columns
Status: RESOLVED FIXED
Product: gom
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gom Maintainers
Gom Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-09 10:51 UTC by Mathieu Bridon
Modified: 2014-05-10 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gom: Add support for NOT NULL constraint on columns (4.93 KB, patch)
2014-05-09 10:51 UTC, Mathieu Bridon 		committed Details | Review
tests: Ensure the NOT NULL constraint works (3.24 KB, patch)
2014-05-09 10:51 UTC, Mathieu Bridon 		committed Details | Review

Description Mathieu Bridon 2014-05-09 10:51:29 UTC 
This is quite a common need for applications, for example to ensure
that no user got added to the database without an email.

First commit adds support, second commit adds a unit test.
Comment 1 Mathieu Bridon 2014-05-09 10:51:33 UTC 
Created attachment 276228 [details] [review]
gom: Add support for NOT NULL constraint on columns
Comment 2 Mathieu Bridon 2014-05-09 10:51:38 UTC 
Created attachment 276229 [details] [review]
tests: Ensure the NOT NULL constraint works
Comment 3 Bastien Nocera 2014-05-09 11:42:20 UTC 
Review of attachment 276228 [details] [review]:

Looks good
Comment 4 Bastien Nocera 2014-05-09 11:42:50 UTC 
Review of attachment 276229 [details] [review]:

Looks good as well.
Comment 5 Mathieu Bridon 2014-05-10 09:56:43 UTC 
Attachment 276228 [details] pushed as b2ef0a4 - gom: Add support for NOT NULL constraint on columns
Attachment 276229 [details] pushed as a5a932c - tests: Ensure the NOT NULL constraint works