GNOME Bugzilla – Bug 729858
Fix and enhance GDatetime for Windows
Last modified: 2018-05-24 16:30:43 UTC
Hi, From bug 719344, there was a patch set to fix and enhance GDatetime on Windows, as in its current state, it does not work very well for non-western locales of Windows, at least (or even non-English Windows). This acts as the bug report to follow up on the patches to remedy this, as bug 719344 seems to be a bit too generic in some ways.
Created attachment 276223 [details] [review] Fix and Enhance GTimezone Hi, This updates GTimezone so that when it queries the Windows registry for standard time and daylight saving time names, it would first query the MUI entries for these in the registry, where possible (i.e. Windows Vista and later). When we query the names in the existing implementation, the names would differ depending on the language version of Windows, which is not optimal, so that we could always get the English strings, for example. This also fixes GTimezone in a way that get the strings tzi->DaylightName and tzi->StandardName correctly, as these strings are actually UTF-16 strings, so that the correct names are acquired as a result.
Created attachment 276355 [details] [review] Fix the GDatetime tests on Windows Hi, This updates the GDatetime tests on Windows so that it will make use of the new MUI items from the registry, if possible, so that we can set the language/locale of the thread. With blessings, thank you!
Hi, pinging this patch, as this would attempt to make GTimezone work better on non-western locales of Windows. With blessings, thank you!
Hi, Any comments or suggestions about the patch here? With blessings, thank you!
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/870.