After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729851 - Avoid Double Null Check
Avoid Double Null Check
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-09 07:18 UTC by Gaurav
Modified: 2014-05-09 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid Double check in xmlregexp.c (379 bytes, patch)
2014-05-09 07:18 UTC, Gaurav 		none Details | Review

Description Gaurav 2014-05-09 07:18:38 UTC 
Created attachment 276210 [details] [review]
Avoid Double check in xmlregexp.c

In file:
https://git.gnome.org/browse/libxml2/tree/xmlregexp.c

    if (atom == NULL)
        return(NULL);
    atom->data = data;
    if (atom == NULL)
	return(NULL);

There is NULL check two times.
This will report error of possible Null pointer dereference.

Attach patch removes double NULL check.
Comment 1 Daniel Veillard 2014-05-09 08:54:33 UTC 
Okay fixed with upstream cleanup commit
41b0d1c4e53dcec2a0206df4bedaad0f81234319

 thanks !

Daniel