GNOME Bugzilla – Bug 729823
Some performance improvements on slider controls
Last modified: 2014-06-26 17:20:27 UTC
No numbers, and a lot of doubts they matter in practice - the one that should do something (the unmapped workspace one) doesn't change anything because the moment you have windows outside the current workspace, you also have the slider fully out always. But heh.
Created attachment 276180 [details] [review] workspace: avoid GObject overhead while computing the clone layout We already have the width and height information cached in JS, let's avoid going through gjs-gobject-clutter to retrieve them again. As a plus, with normal properties the optimizer should be able to generate better code.
Created attachment 276181 [details] [review] WorkspacesView: separate setting the full and the actual geometry They are different properties, they deserve different syncs. Especially because a full allocation cycle sets both anyway, so we should save some cycles this way.
Created attachment 276182 [details] [review] Workspace: ignore actual geometry changes while unmapped If unmapped, ignore geometry changes. This avoids doing useless layout work on invisible workspaces during the slider control animations.
Created attachment 276183 [details] [review] WorkspacesView: don't access the allocation 4 times Access it once, and save 3 GObject property accesses and related copies.
Review of attachment 276180 [details] [review]: OK not sure this makes a measurable difference but its not like it makes the code way more compex or something.
Review of attachment 276181 [details] [review]: Makes sense.
Review of attachment 276182 [details] [review]: OK.
Review of attachment 276183 [details] [review]: OK.
Attachment 276180 [details] pushed as 0271835 - workspace: avoid GObject overhead while computing the clone layout Attachment 276181 [details] pushed as 309d40a - WorkspacesView: separate setting the full and the actual geometry Attachment 276182 [details] pushed as 7d7b924 - Workspace: ignore actual geometry changes while unmapped Attachment 276183 [details] pushed as 37ef0e4 - WorkspacesView: don't access the allocation 4 times