After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729796 - Leaking GTasks when calling g_task_return_error_if_cancelled()
Leaking GTasks when calling g_task_return_error_if_cancelled()
Status: RESOLVED NOTABUG
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-05-08 08:06 UTC by Sebastian Dröge (slomo)
Modified: 2014-05-08 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Don-t-leak-tasks-in-GInputStream-and-GOutputStream-w.patch (1.37 KB, patch)
2014-05-08 08:06 UTC, Sebastian Dröge (slomo) 		rejected Details | Review

Description Sebastian Dröge (slomo) 2014-05-08 08:06:27 UTC 
Created attachment 276137 [details] [review]
0001-Don-t-leak-tasks-in-GInputStream-and-GOutputStream-w.patch

See attached patch, some other occurences of this pattern were already fixed previously in bug #726611.
Comment 1 Dan Winship 2014-05-08 13:00:28 UTC 
in both cases, the task is unreffed by the calling function (g_input_stream_real_read_async() and g_output_stream_real_write_async())
Comment 2 Sebastian Dröge (slomo) 2014-05-08 13:05:15 UTC 
Comment on attachment 276137 [details] [review]
0001-Don-t-leak-tasks-in-GInputStream-and-GOutputStream-w.patch

How confusing, thanks :)