GNOME Bugzilla – Bug 729778
Incorrect item deletion in recent view
Last modified: 2014-05-15 17:33:05 UTC
How to reproduce: * open Recent view; * add one and the same file several times (I've added file for three times); * right-click on any of added files; * select all added files; * click on "Delete" button. Result: * Recent view hasn't deleted all selected files.
Right, we shouldn't allow adding the same file three times to be fair.
This is actually worse than that. It might remove some other unrelated items.
commit 524c9e39a0ca6f2d1699e6e6d9ba3db1ea80d9f9 Author: Bastien Nocera <hadess@hadess.net> Date: Thu May 15 19:28:35 2014 +0200 main: Fix potential data loss when removing multiple files We were using a list of GtkTreePaths and deleting the items one-by-one when the user clicked the "Delete" button. But after the first deletion, the tree model would have changed, and instead of pointing to the 2nd item we wanted to delete, the GtkTreePath would have pointed to another item, usually not one that we wanted to delete. We now use GtkTreeRowReferences, which will always point to the same row, as long as it exists. https://bugzilla.gnome.org/show_bug.cgi?id=729778