After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729778 - Incorrect item deletion in recent view
Incorrect item deletion in recent view
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-08 06:19 UTC by Yuri Myasoedov
Modified: 2014-05-15 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Yuri Myasoedov 2014-05-08 06:19:12 UTC
How to reproduce:

 * open Recent view;
 * add one and the same file several times (I've added file for three times);
 * right-click on any of added files;
 * select all added files;
 * click on "Delete" button.

Result:

 * Recent view hasn't deleted all selected files.
Comment 1 Bastien Nocera 2014-05-15 14:48:35 UTC
Right, we shouldn't allow adding the same file three times to be fair.
Comment 2 Bastien Nocera 2014-05-15 17:21:57 UTC
This is actually worse than that. It might remove some other unrelated items.
Comment 3 Bastien Nocera 2014-05-15 17:33:05 UTC
commit 524c9e39a0ca6f2d1699e6e6d9ba3db1ea80d9f9
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu May 15 19:28:35 2014 +0200

    main: Fix potential data loss when removing multiple files
    
    We were using a list of GtkTreePaths and deleting the items one-by-one
    when the user clicked the "Delete" button. But after the first deletion,
    the tree model would have changed, and instead of pointing to the 2nd
    item we wanted to delete, the GtkTreePath would have pointed to another
    item, usually not one that we wanted to delete.
    
    We now use GtkTreeRowReferences, which will always point to the same
    row, as long as it exists.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729778