After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729758 - Replace all goes infinite loop for recursive patterns
Replace all goes infinite loop for recursive patterns
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: general
1.8.x
Other Linux
: Normal normal
: ---
Assigned To: meld-maint
meld-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-08 00:08 UTC by Balint Reczey
Modified: 2014-05-24 02:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix loop on replace all (1.00 KB, patch)
2014-05-19 12:27 UTC, Louis 		none Details | Review

Description Balint Reczey 2014-05-08 00:08:43 UTC 
Run: 

echo bar > foo; meld foo foo

Edit -> Replace
Search for: a
Replace With: ab

Click "Replace All"

At this point Meld goes into an infinite loop.
Comment 1 Louis 2014-05-19 12:27:49 UTC 
Created attachment 276765 [details] [review]
Fix loop on replace all
Comment 2 Kai Willadsen 2014-05-23 21:01:22 UTC 
That patch looks good to me; I've applied the fix to master. Thanks!

For future reference, I'm using a slightly different commit message style for Meld, prefixing the module changed (when it's a single module) and just giving the bug number as a bgo#XXXXXX reference in brackets, so that commit could have been
    ui.findbar: Fix loop on replace all (bgo#729758)

Thanks for the bug report.
Comment 3 Louis 2014-05-24 02:00:54 UTC 
And for reference, this change can be made to git-bz like so:
git config bz.add-url-method subject-append:"(bgo#%d)"