After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729754 - Add missing (nullable) annotations on return values
Add missing (nullable) annotations on return values
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks: 729745
 
 
Reported: 2014-05-07 23:31 UTC by Evan Nemerson
Modified: 2014-06-07 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
introspection: add some missing Returns: (nullable) annotations (3.43 KB, patch)
2014-05-07 23:31 UTC, Evan Nemerson
committed Details | Review

Description Evan Nemerson 2014-05-07 23:31:17 UTC
Created attachment 276111 [details] [review]
introspection: add some missing Returns: (nullable) annotations

Now that bug #660879 has been fixed, I'm trying to go through and add the
missing annotations.

I've never used at-spi, so I'm not too familiar with the API, but I've gone
through all of the Returns tags and, where there is text mentioning a potential
NULL return value, I've added a (nullable) annotation.  I'm sure there are
other functions which may return NULL but I doubt I have added annotations
where they aren't appropriate, so this should be safe.
Comment 1 Mike Gorse 2014-06-07 20:11:18 UTC
That seems fine. Thanks for the patch.