After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729743 - glcolorconvert: Should preserve alpha channel when doing AYUV -> ARGB
glcolorconvert: Should preserve alpha channel when doing AYUV -> ARGB
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-07 19:25 UTC by Nicolas Dufresne (ndufresne)
Modified: 2014-05-11 04:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Dufresne (ndufresne) 2014-05-07 19:25:33 UTC 
Currently it always set the alpha to 1.0 using frag_AYUV_to_RGB

    "  a = 1.0;\n"
Comment 1 Matthew Waters (ystreet00) 2014-05-09 12:32:52 UTC 
commit d8ac00189562fa7b50bd19bffc1f84738bbcceab
Author: Matthew Waters <ystreet00@gmail.com>
Date:   Fri May 9 22:22:43 2014 +1000

    gl/colorconvert: preserve alpha in AYUV <-> RGBA conversions
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729743
Comment 2 Nicolas Dufresne (ndufresne) 2014-05-09 14:13:59 UTC 
Thanks, note the hash did not match:
2dcbf08d735e19ea72d8f0b7b6658d9a82b78425
Comment 3 Nicolas Dufresne (ndufresne) 2014-05-09 14:16:29 UTC 
+    "  vec4 texel;\n"
+    "  texel = texture2D(tex, v_texcoord * tex_scale0);\n"
+    "  texel.gba += offset;\n"
+    "  r = dot(texel.gba, coeff1);\n"
+    "  g = dot(texel.gba, coeff2);\n"
+    "  b = dot(texel.gba, coeff3);\n"
+    "  a = texel.a;\n"

Shouldn't it be a = texel.r ? (did test yet, will do this afternoon.
Comment 4 Matthew Waters (ystreet00) 2014-05-11 04:06:09 UTC 
Yes, it should ;)

commit 91717ca5c2e0dd8429bb37046674be5df188164a
Author: Matthew Waters <ystreet00@gmail.com>
Date:   Sun May 11 14:02:34 2014 +1000

    gl/colorconvert: choose the right alpha component for AYUV -> RGBA