After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729715 - Improvements on the Fortran language file
Improvements on the Fortran language file
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-07 13:48 UTC by Fulguritus
Modified: 2014-05-10 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improvements on the Fortran language file (5.73 KB, patch)
2014-05-07 13:48 UTC, Fulguritus 		reviewed Details | Review

Description Fulguritus 2014-05-07 13:48:58 UTC 
Created attachment 276069 [details] [review]
Improvements on the Fortran language file

Hi, 

I made some improvements on the Fortran language file (see attached patch): 
 * Added some Fortran 2008 Keywords
 * `size` is an intrinsic function, removed duplicate entry
 * Added precompiler directives
 * Excluded `character` from comments

Would it be possible to include those upstream? 

Thanks a lot! 

Alex
Comment 1 Sébastien Wilmet 2014-05-09 20:17:00 UTC 
Review of attachment 276069 [details] [review]:

See the comment below. Apart from that the other changes seem fine (I don't know Fortran).
Note: the commit must not be pushed for gnome-3-12, since it contains new translatable strings.

::: data/language-specs/fortran.lang
@@ +26,3 @@
   <metadata>
     <property name="mimetypes">text/x-fortran</property>
+    <property name="globs">*.f;*.f90;*.f95;*.for;*.F;*.F90</property>

Are the *.F and *.F90 standard file extensions for Fortran?
Comment 2 Fulguritus 2014-05-10 06:55:37 UTC 
Hi Sébastien, 

the capital "F*" indicates that a preprocessor is to be used, while "f*" means no preprocessor. This is a quasi-standard and supported (at least) by GCC and Intel's ifort. 

BTW: "[fF]95", "[fF]03", "[fF]08" (for the 95, 2003, and 2008 standard, respectively) are rarely used and not supported by all compilers. Typically, one uses ".f" for fixed form (FORTRAN 77 and lower) and ".[fF]90" for Fortran 90+. ".for" only appears in *really* old source code. 

Regards, 
Alex