After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729689 - [review] dcbw/kill-policy-hosts: remove old /etc/hosts cleaning functions
[review] dcbw/kill-policy-hosts: remove old /etc/hosts cleaning functions
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-07 03:41 UTC by Dan Williams
Modified: 2014-05-09 16:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Williams 2014-05-07 03:41:11 UTC
NetworkManager stopped touching /etc/hosts in late 2010 before the
NetworkManager 0.8.1 release.  The code in nm-policy-hosts.c's only
purpose is to remove any of the entries that NetworkManager added long
ago.

I think we're at the point where people have already upgraded to
NetworkManager 0.8.1 or later and thus this code would be a NOP.  The
only risk is that some stale /etc/hosts entries will be left if you
upgrade from NM 0.8 or lower to anything higher than that.

FWIW, Ubuntu Lucid (10.04) ships NM 0.8.0 and SLES11 ships NM 0.7.0, so
if users of these distros upgraded to a later NetworkManager they might
run into the stale entries issue if we remove this code from NM.  But
given how old these distros are, it seems unlikely that users will do a
direct upgrade to something 4+ years newer...
Comment 1 Thomas Haller 2014-05-07 12:06:46 UTC
Acked-by: Thomas Haller <thaller@redhat.com>
Comment 2 Dan Winship 2014-05-07 18:22:25 UTC
what he said
Comment 3 Dan Williams 2014-05-08 20:21:54 UTC
Merged.