GNOME Bugzilla – Bug 729682
Make the category view sidebar match the mockup more closely
Last modified: 2014-08-03 23:25:17 UTC
Created attachment 276026 [details] Result This is the mockup: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/software/version2/hi-res-category.png Attached screenshot: How it looks with my patch I'll attach the patch in a minute.
Created attachment 276027 [details] [review] [PATCH] Make the category view sidebar match the mockup more closely
Review of attachment 276027 [details] [review]: ::: src/gs-shell-category.ui @@ +14,1 @@ <property name="margin-right">12</property> Pleasw, use margin-start and margin-end instead. ::: src/gtk-style.css @@ +141,3 @@ +.listbox_filter GtkListBoxRow { + padding-left: 5px; +} Please, add once for rtl, like: .listbox_filter GtkListBoxRow:dir(rtl) { padding-right: 5px; }
Created attachment 276092 [details] [review] [PATCH] Make the category view sidebar match the mockup more closely Done
Review of attachment 276092 [details] [review]: ::: src/gtk-style.css @@ +140,3 @@ + +.listbox_filter GtkListBoxRow { + padding-left: 5px; Sorry, you forget to add here :dir(ltr) so this style apply on ltr only, not rtl too.
If GTK respects the CSS standard, the more specific selectors will take precedence. dir(rtl) is a more specific selector. It's also further down the file so that boosts its priority too. Therefor, the selector you quoted here will not be applied on rtl. I tested it and it seems to work as intended, so I'm not going to make this change. Have you even tried to run gnome-software with my patch and see for yourself?
Still waiting for review :)
I went through this and fixed up the issues you mentioned at GUADEC and pushed the patch. Good stuff, thanks Elad! The final result looks like this: https://kalev.fedorapeople.org/gnome-software-category-sidebar.png