GNOME Bugzilla – Bug 729680
Some HTML entities not unescaped by grl.unescape()
Last modified: 2014-12-05 10:57:54 UTC
There's a good bunch of non-numerical entities which we should be supporting: http://www.w3.org/TR/html4/sgml/entities.html We might need to revise the current code slightly to be more easily extensible.
Created attachment 291657 [details] [review] lua-factory: Add htmlentity files from GtkHTML
Created attachment 291658 [details] [review] lua-factory: Use HTML entities helper Which now supports more entities than what we supported.
Review of attachment 291657 [details] [review]: ::: src/lua-factory/Makefile.am @@ +33,3 @@ grl-lua-common.h \ + htmlentity.c \ + htmlentity.h \ It is probably interesting to move this files inside lua-library/
Review of attachment 291658 [details] [review]: My intention at first with lua-library folder was to separate functions that had dependencies and also to avoid making grl-lua-library.c growing too much. Apart from that, really good improvement.
Created attachment 292176 [details] [review] lua-factory: Add htmlentity files from GtkHTML
Created attachment 292177 [details] [review] lua-factory: Use HTML entities helper Which now supports more entities than what we supported.
Attachment 292176 [details] pushed as 042a5dc - lua-factory: Add htmlentity files from GtkHTML Attachment 292177 [details] pushed as 74604bd - lua-factory: Use HTML entities helper