After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729639 - app.vala compile error
app.vala compile error
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.37.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-06 11:35 UTC by Egmont Koblinger
Modified: 2014-05-06 19:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Egmont Koblinger 2014-05-06 11:35:39 UTC
Compiling git master on ubuntu trusty fails:

  VALAC    vte_2_91_vala.stamp
app.vala:360.42-360.46: error: Argument 1: Cannot convert from `Gdk.EventButton' to `Gdk.Event'
		var match = terminal.match_check_event(event, null);
		                                       ^^^^^
Compilation failed: 1 error(s), 0 warning(s)

I assume it works on your system ChPe, so it must be a change in Gtk or whatever, not sure in which direction.

(Commenting out the "var match = ..." and the subsequent statement relying on "match" makes it compile, so this is the only error.)
Comment 1 Christian Persch 2014-05-06 16:26:05 UTC
I guess this doesn't work before the vala change from bug 713240…

We could either add a #if for the old vala version, or bump the required vala version?
Comment 2 Egmont Koblinger 2014-05-06 19:20:43 UTC
I vote for an #if on vala version – it's nice if vte can be compiled without errors. IMO let's lose an unimportant feature in vteapp rather than scaring people with a failing compilation, or requiring them to upgrade their vala.
Comment 3 Christian Persch 2014-05-06 19:33:33 UTC
Try now with git master.
Comment 4 Egmont Koblinger 2014-05-06 19:38:59 UTC
Cool, thanks!