After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729614 - PNM Encoder is Encoding 0 x 0 images
PNM Encoder is Encoding 0 x 0 images
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-06 04:04 UTC by Sanjay NM
Modified: 2014-05-08 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixed this issue by adding an error check. (947 bytes, patch)
2014-05-06 04:04 UTC, Sanjay NM 		committed Details | Review
pnmenc: remove empty line (776 bytes, patch)
2014-05-06 13:56 UTC, Luis de Bethencourt 		committed Details | Review
pnmenc: Zero check to fields not required (841 bytes, patch)
2014-05-08 13:00 UTC, Sanjay NM 		none Details | Review

Description Sanjay NM 2014-05-06 04:04:26 UTC 
Created attachment 275934 [details] [review]
Fixed this issue by adding an error check.

PNM Encoder continues to encode even if the width, height is zero. Encoded image has width, height as zero with the input buffer dumped into the image

Fixed this issue by adding an error check. Attached is the Patch file, request to review.
Comment 1 Luis de Bethencourt 2014-05-06 04:27:28 UTC 
Looks good to me. And tested.
Comment 3 Tim-Philipp Müller 2014-05-06 08:51:09 UTC 
commit e807ac077d24bbefb48bb88dd16cff714f5e0195
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue May 6 09:48:58 2014 +0100

    pnmenc: fix flow return and buffer leak in not-negotiated case
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729614
Comment 4 Luis de Bethencourt 2014-05-06 13:55:57 UTC 
The following fix has been pushed:
bf1997f pnmenc: remove empty line
Comment 5 Luis de Bethencourt 2014-05-06 13:56:00 UTC 
Created attachment 275979 [details] [review]
pnmenc: remove empty line

Remove trailing empty line from commit bfdc54395238c04fc6e5b51880c2d706f33e9011
Comment 6 Sanjay NM 2014-05-08 13:00:35 UTC 
Created attachment 276155 [details] [review]
pnmenc: Zero check to fields not required

Zero check to fields not required. Removed it