After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729607 - GtkAboutDialog: gtk aborts when trying to show an about dialog
GtkAboutDialog: gtk aborts when trying to show an about dialog
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-05 22:40 UTC by Juan Pablo Ugarte
Modified: 2014-05-06 03:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Test case (391 bytes, text/x-csrc)
2014-05-05 22:40 UTC, Juan Pablo Ugarte
  Details
Proposed patch (1.36 KB, patch)
2014-05-05 22:44 UTC, Juan Pablo Ugarte
none Details | Review

Description Juan Pablo Ugarte 2014-05-05 22:40:41 UTC
Created attachment 275924 [details]
Test case

The problem is in GtkViewport reporting a wrong size.

(a.out:19508): Gtk-CRITICAL **: _gtk_widget_get_preferred_size_for_size: assertion 'size >= -1' failed

(a.out:19508): Gtk-WARNING **: GtkViewport 0x1a7e130 reported min size 27779380 and natural size 4 in get_preferred_width(); natural size must be >= min size

(a.out:19508): Gtk-CRITICAL **: _gtk_widget_get_preferred_size_for_size: assertion 'size >= -1' failed

(a.out:19508): Gtk-WARNING **: GtkViewport 0x1a7e130 reported min size 27779380 and natural size 4 in get_preferred_height(); natural size must be >= min size

(a.out:19508): Gdk-WARNING **: Native Windows wider or taller than 32767 pixels are not supported
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
**
Gdk:ERROR:gdkcairo.c:193:gdk_cairo_surface_paint_pixbuf: assertion failed: (cairo_image_surface_get_format (surface) == CAIRO_FORMAT_RGB24 || cairo_image_surface_get_format (surface) == CAIRO_FORMAT_ARGB32)
Aborted
Comment 1 Juan Pablo Ugarte 2014-05-05 22:44:00 UTC
Created attachment 275925 [details] [review]
Proposed patch

The problem was introduced in commit 29a4f0131e7f2a8ec3c0e4949d00dfed255d5995
calling _gtk_widget_get_preferred_size_for_size() with a size lower than -1

The patch removes the checks and let any negative value mean the size it not set rather than just -1.
Comment 2 Benjamin Otte (Company) 2014-05-06 02:11:15 UTC
I fixed GtkViewport to not go below -1. I don't think it's a good idea to
allow any negative number in size request code. We want to keep -1 as the only
value for "undefined".
Comment 3 Juan Pablo Ugarte 2014-05-06 03:14:23 UTC
OK great, yeah that was my first approach too, but then Matthias and I tough It might be good to accept any negative value.