After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729494 - Disable dark theme plugin does not disable the dark theme
Disable dark theme plugin does not disable the dark theme
Status: RESOLVED FIXED
Product: eog-plugins
Classification: Core
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-04 09:04 UTC by János Illés
Modified: 2019-02-22 03:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Dark EOG window with the plugin enabled (64.96 KB, image/png)
2014-05-04 09:04 UTC, János Illés
Details

Description János Illés 2014-05-04 09:04:55 UTC
Created attachment 275794 [details]
Dark EOG window with the plugin enabled

The Disable dark theme plugin works right after it is enabled, but after closing and reopening the EOG window will be dark again. 

This started after upgrading to 3.12 and still exists with 3.12.1
Comment 1 Felix Riemann 2014-05-04 12:27:32 UTC
The plugin needs an open display to change the theme setting. However, since 3.12 the display is opened quite a bit later when starting eog. Additionally the per-app plugins are activated at the wrong place, which causes the plugin to activate before the display is available.

The fix moves per-app plugin activation at the end of the startup which also avoids the unneeded activation of the plugins when just reusing an existing eog instance.

commit 066be17db6a58b55d7c93d7bcb43c2a7fae050ad
Author: Felix Riemann <>
Date:   Sun May 4 14:13:54 2014 +0200

    EogApplication: Activate per-app plugins in the startup callback
    
    If activated in the init function the application could not be
    as initialized as expected by the plugins. Also this avoids the
    unneeded plugin enumeration when reusing an instance.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729494
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Felix Riemann 2014-05-12 20:50:07 UTC
Applied to the gnome-3-12 stable branch as well.