After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729489 - gnome-shell only use libgsystem on Linux
gnome-shell only use libgsystem on Linux
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-05-04 03:52 UTC by Ting-Wei Lan
Modified: 2014-05-06 01:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] 3.14: gnome-shell only use libgsystem on linux (894 bytes, patch)
2014-05-04 03:54 UTC, Ting-Wei Lan 		needs-work Details | Review
[PATCH] 3.14: gnome-shell only use libgsystem on linux (1.04 KB, patch)
2014-05-05 15:23 UTC, Ting-Wei Lan 		accepted-commit_now Details | Review

Description Ting-Wei Lan 2014-05-04 03:52:24 UTC 
gnome-shell does not use libgsystem on non-systemd system because libgsystem itself is not portable.

https://git.gnome.org/browse/gnome-shell/commit/?id=8c45e6fa43f49ffef0bf1839f08c1610adc706cc
Comment 1 Ting-Wei Lan 2014-05-04 03:54:00 UTC 
Created attachment 275791 [details] [review]
[PATCH] 3.14: gnome-shell only use libgsystem on linux

 modulesets/gnome-suites-core-3.14.modules | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 2 Matthias Clasen 2014-05-05 11:39:13 UTC 
Review of attachment 275791 [details] [review]:

Could you just move it into the existing block of linux-only dependencies a few lines down, instead ?
Comment 3 Ting-Wei Lan 2014-05-05 15:23:37 UTC 
Created attachment 275894 [details] [review]
[PATCH] 3.14: gnome-shell only use libgsystem on linux

 modulesets/gnome-suites-core-3.14.modules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Matthias Clasen 2014-05-06 01:46:59 UTC 
Review of attachment 275894 [details] [review]:

looks good now, thanks