After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729487 - The GESEffect.active property is deserialized from xges always as True
The GESEffect.active property is deserialized from xges always as True
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-04 00:45 UTC by Alex Băluț
Modified: 2015-06-24 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xml-formatter: Do not forget to set properties on the track elements (1.04 KB, patch)
2014-11-01 10:33 UTC, Thibault Saunier 		none Details | Review
xml-formatter: Do not forget to set properties on the track elements (1.06 KB, patch)
2014-11-02 13:03 UTC, Thibault Saunier 		committed Details | Review

Description Alex Băluț 2014-05-04 00:45:31 UTC 
Steps to reproduce:
- Add a clip to the timeline in Pitivi, add an effect to it, mark it as non active, save the project.
- Restart the app, notice the effect is active when it should be not.

For example:

          <effect asset-id='agingtv' clip-id='0' type-name='GESEffect' track-type='4' track-id='0' properties='properties, priority=(uint)3, active=(boolean)false, track-type=(int)4;' metadatas='metadatas;' children-properties='properties, qos=(boolean)true, scratch-lines=(uint)7, color-aging=(boolean)true, pits=(boolean)true, dusts=(boolean)true;'>

effect.props.active == True when it should be False when the project is loaded from the xges file.
Comment 1 Thibault Saunier 2014-11-01 10:33:27 UTC 
Created attachment 289775 [details] [review]
xml-formatter: Do not forget to set properties on the track elements

We were just setting children properties, even if the propertie to be
set on themselves where properly passed in
Comment 2 Thibault Saunier 2014-11-02 13:03:18 UTC 
Created attachment 289835 [details] [review]
xml-formatter: Do not forget to set properties on the track elements

We were just setting children properties, even if the propertie to be
set on themselves where properly passed in
Comment 3 Thibault Saunier 2014-11-10 16:27:50 UTC 
Attachment 289835 [details] pushed as 21807d6 - xml-formatter: Do not forget to set properties on the track elements