After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729478 - Use the correct name of the parent widget in the .ui files
Use the correct name of the parent widget in the .ui files
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-03 20:49 UTC by Yosef Or Boczko
Modified: 2014-05-04 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Use the correct name of the parent widget (2.26 KB, patch)
2014-05-03 20:50 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-05-03 20:49:54 UTC 
Example: Gtk.Paned -> GtkPaned

It cause to gitg crash without the patch:
$ gitg

(gitg:25394): Gtk-CRITICAL **: Error building template class 'GitgWindow' for an instance of type 'GitgWindow': Invalid template parent type `Gtk.ApplicationWindow'

(gitg:25394): Gtk-CRITICAL **: gtk_search_bar_connect_entry: assertion 'GTK_IS_SEARCH_BAR (bar)' failed

(gitg:25394): GLib-GObject-CRITICAL **: g_object_bind_property_full: assertion 'G_IS_OBJECT (source)' failed

(gitg:25394): Gtk-CRITICAL **: gtk_stack_switcher_set_stack: assertion 'GTK_IS_STACK_SWITCHER (switcher)' failed

(gitg:25394): GLib-GObject-CRITICAL **: g_object_set: assertion 'G_IS_OBJECT (object)' failed

(gitg:25394): Gtk-CRITICAL **: gtk_container_remove: assertion 'GTK_IS_CONTAINER (container)' failed

(gitg:25394): Gtk-CRITICAL **: gtk_container_remove: assertion 'GTK_IS_CONTAINER (container)' failed

(gitg:25394): Gtk-CRITICAL **: gtk_container_remove: assertion 'GTK_IS_CONTAINER (container)' failed

(gitg:25394): Gtk-CRITICAL **: gtk_widget_get_parent: assertion 'GTK_IS_WIDGET (widget)' failed
Segmentation fault (core dumped)
Comment 1 Yosef Or Boczko 2014-05-03 20:50:30 UTC 
Created attachment 275763 [details] [review]
ui: Use the correct name of the parent widget
Comment 2 Paolo Borelli 2014-05-04 09:26:47 UTC 
Review of attachment 275763 [details] [review]:

thanks
Comment 3 Yosef Or Boczko 2014-05-04 09:40:34 UTC 
Review of attachment 275763 [details] [review]:

Pushed as a7c5eda - ui: Use the correct name of the parent widget