After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729462 - DeviceManagerXi2: Update cached core pointer in getter if NULL
DeviceManagerXi2: Update cached core pointer in getter if NULL
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: x11
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-03 15:59 UTC by Jonas Ådahl
Modified: 2014-12-15 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
DeviceManagerXi2: Update cached core pointer in getter if NULL (1.08 KB, patch)
2014-05-03 15:59 UTC, Jonas Ådahl 		committed Details | Review
Stop use XGetClientPointer (4.62 KB, patch)
2014-05-20 13:18 UTC, Sjoerd Simons 		committed Details | Review

Description Jonas Ådahl 2014-05-03 15:59:13 UTC 
XIGetClientPointer() may return the device id '0' when called early.
This patch makes pointer cursors work in nested mutter Wayland
sessions again.
Comment 1 Jonas Ådahl 2014-05-03 15:59:15 UTC 
Created attachment 275751 [details] [review]
DeviceManagerXi2: Update cached core pointer in getter if NULL
Comment 2 Sjoerd Simons 2014-05-20 09:52:51 UTC 
I just hit exactly the same issue with clutters own perf-test-state-pick  on X11 directly.  Your patch does fix things for me, however it does make me wonder when we can rely on the core pointer being available, as updating it lazily in the getter is still a potential race
Comment 3 Sjoerd Simons 2014-05-20 13:18:17 UTC 
Created attachment 276858 [details] [review]
Stop use XGetClientPointer

Different approach to solve the same problem. XGetClientPointer seems a pretty bogus API to use in the first place, by avoiding it we can solve this issue hopefully a bit nicer and make it not-racy..
Comment 4 Emmanuele Bassi (:ebassi) 2014-12-15 17:48:10 UTC 
Attachment 275751 [details] pushed as 5281425 - DeviceManagerXi2: Update cached core pointer in getter if NULL