After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729405 - Deprecate GNOME_CODE_COVERAGE
Deprecate GNOME_CODE_COVERAGE
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-05-02 15:09 UTC by Philip Withnall
Modified: 2015-05-26 21:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
macros2: Deprecate GNOME_CODE_COVERAGE (14.44 KB, patch)
2014-08-25 23:16 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-05-02 15:09:29 UTC 
After discussion with David at the developer hackfest, the GNOME_CODE_COVERAGE macro should be moved to the autoconf-archive[1], since it has wider application than just within GNOME.

The upstreamed macro could then be copied back into gnome-common, or copied into the m4 directory in each project which uses it. I suggest the latter, since it interacts quite closely with the module’s build system, so should be next to it rather than in an external module.

[1]: http://www.gnu.org/software/autoconf-archive/
Comment 1 Philip Withnall 2014-05-10 18:19:00 UTC 
Submitted to autoconf-archive here: http://savannah.gnu.org/patch/index.php?8451
Comment 2 Philip Withnall 2014-08-25 23:16:51 UTC 
Created attachment 284461 [details] [review]
macros2: Deprecate GNOME_CODE_COVERAGE

The autoconf-archive AX_CODE_COVERAGE macro should be used instead.
Comment 3 David King 2014-08-26 07:39:02 UTC 
Review of attachment 284461 [details] [review]:

Looks fine. Do any of this and the other deprecations need a bump to the M4 serial?
Comment 4 Philip Withnall 2014-08-28 17:46:47 UTC 
Attachment 284461 [details] pushed as f07add2 - macros2: Deprecate GNOME_CODE_COVERAGE
Comment 5 Philip Withnall 2014-09-15 11:06:04 UTC 
The upstream version has been pushed to the archive: https://savannah.gnu.org/patch/?8451

David, perhaps one of us should blog about this? Or is it too early?
Comment 6 David King 2014-09-15 11:14:32 UTC 
Cool! Probably best that you blog, as you did the work and are on Planet GNOME.
Comment 7 Eric Gallager 2014-11-20 23:09:04 UTC 
This caused the same conflict with the autoconf-archive package as I mentioned in https://bugzilla.gnome.org/show_bug.cgi?id=729403#c6
(but with ax_code_coverage.m4 here, as opposed to ax_check_enable_debug.m4 in the other one)
Comment 8 David King 2015-05-26 21:41:51 UTC 
(In reply to Eric Gallager from comment #7)

That is now covered by bug 747920 (with a patch that will be applied soon).