GNOME Bugzilla – Bug 729379
Tries to use deactivated proxy
Last modified: 2014-05-07 10:27:36 UTC
sound-juicer-3.11.90-1.fc20.x86_64 ** (sound-juicer:22555): WARNING **: No Musicbrainz metadata for discid gNB2ddg0g9OpThwo0lqBgLQoQVQ-, http code 0, Could not resolve hostname `squid.redhat.com': Host not found $ gsettings get org.gnome.system.proxy mode 'none' But it still tries to use the http proxy settings nonetheless.
It is ignoring the mode key altogether I'll get on and fix it next week
Created attachment 275985 [details] [review] libjuicer: Add support for the "none" proxy mode This stops sound-juicer from using a proxy even when that one is actually deactivated in the preferences.
Review of attachment 275985 [details] [review]: I wonder if we would be better using GProxyResolver rather than reading the proxy settings directly so we can support G_DESKTOP_PROXY_MODE_AUTO as well. The Resolver would have to be queried inside SjMetadataMusicbrainz5 rather than SjMetadata as g_proxy_resolver_lookup() needs a url. That would make the proxy properties of SjMetadata redundant. Christophe wasn't keen when I tried to move the proxy handling into SjMetadataMusicbrainz5 and remove the properties from SjMetadata before but it would be good to support the auto proxy mode. Also we should think about what to do with the http_proxy environment variable. If it's set then libmusicbrainz uses it if we don't explicitly set a proxy. That means if a user starts sound-juicer and then sets the proxy mode to 'none' sound-juicer will still use the proxy as the http_proxy environment variable will still be set. ::: libjuicer/sj-metadata-musicbrainz5.c @@ +809,3 @@ mb5_query_set_proxyhost (priv->mb, NULL); mb5_query_set_proxyport (priv->mb, 0); mb5_query_set_proxyusername (priv->mb, NULL); Need to change the else at the end of this block to else if (priv->proxy_mode == G_DESKTOP_PROXY_MODE_MANUAL) to avoid using the manual proxy if the mode is G_DESKTOP_PROXY_MODE_AUTO
Created attachment 276028 [details] [review] libjuicer: Add support for the "none" proxy mode This stops sound-juicer from using a proxy even when that one is actually deactivated in the preferences.
I think this is probably good enough for now, and then we can add support for the automatic mode in a separate bug.
Review of attachment 276028 [details] [review]: I've not tried compiling it but it looks good to me.
(In reply to comment #5) > I think this is probably good enough for now, and then we can add support for > the automatic mode in a separate bug. OK, I've opened bug 729702 for this.
Attachment 276028 [details] pushed as a7da3e8 - libjuicer: Add support for the "none" proxy mode