GNOME Bugzilla – Bug 729378
Disregard "The" in titles
Last modified: 2014-11-04 22:01:23 UTC
It would be nice if Music sorted albums (and perhaps artists and tracks) starting with "The" after the string following "the". It could also change the presentation, so an album named "The Album" would show up as "Album, the". Searching should probably find both variants.
Yeah, we definitely should implement this, extending the same to artists, though I'm not sure about the tracks
We should also make sure this is translatable - see https://github.com/gnumdk/lollypop/issues/3#issuecomment-59149670
Created attachment 289149 [details] [review] changed 'order by' for query.artists() and query.albums(): sorting now disregards 'the' at beginning of artist/album name
(In reply to comment #3) > Created an attachment (id=289149) [details] [review] > changed 'order by' for query.artists() and query.albums(): sorting now > disregards 'the' at beginning of artist/album name Good job, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=7f0dc8d Keeping the bug open as we still need to implement translations for this
Created attachment 289599 [details] [review] ORDER BY statements generated by order_by_statement function, nested if statements to ignore multiple articles, _('the') for translatability
(In reply to comment #5) > Created an attachment (id=289599) [details] [review] > ORDER BY statements generated by order_by_statement function, nested if > statements to ignore multiple articles, _('the') for translatability Looks good, but query.py lacks 'from gettext import gettext as _'
Created attachment 289982 [details] [review] ORDER BY statements generated by order_by_statement function, nested if statements to ignore multiple articles, _('the') for translatability. INCLUDES 'IMPORT GETTEXT'.
(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=289599) [details] [review] [details] [review] > > ORDER BY statements generated by order_by_statement function, nested if > > statements to ignore multiple articles, _('the') for translatability > > Looks good, but query.py lacks 'from gettext import gettext as _' Whoops, my bad! Put in the import statement and reposted the patch--see comment #7.
Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=93555cf in master