Created attachment 275577 [details] [review]
Make Maps DBus activatable

Created attachment 275578 [details] [review]
Rename desktop file to GApplication application ID

This is needed in order to advertise that we support DBus activation.

Created attachment 275579 [details] [review]
Advertise DBus activatable status in desktop file

Review of attachment 275578 [details] [review]:

What's missing here is all the references in the po files to the old gnome-maps.desktop name.

#: ../data/gnome-maps.desktop.in.in.h:1 ../src/application.js:55
#: ../src/mainWindow.js:372 ../src/main-window.ui.h:3
msgid "Maps"
msgstr "الخرائط"

#: ../data/gnome-maps.desktop.in.in.h:2
msgid "A simple maps application"
msgstr "تطبيق خرائط بسيط"

#: ../data/gnome-maps.desktop.in.in.h:3
msgid "Maps;"
msgstr "خرائط;"

How do I deal with that? Just rename it in all po files?

(In reply to comment #4)
> Review of attachment 275578 [details] [review]:
> 
> What's missing here is all the references in the po files to the old
> gnome-maps.desktop name.
> 
> #: ../data/gnome-maps.desktop.in.in.h:1 ../src/application.js:55
> #: ../src/mainWindow.js:372 ../src/main-window.ui.h:3
> msgid "Maps"
> msgstr "الخرائط"
> 
> #: ../data/gnome-maps.desktop.in.in.h:2
> msgid "A simple maps application"
> msgstr "تطبيق خرائط بسيط"
> 
> #: ../data/gnome-maps.desktop.in.in.h:3
> msgid "Maps;"
> msgstr "خرائط;"
> 
> How do I deal with that? Just rename it in all po files?

Its dealt with the same way as any other source file: you don't. :) The source code file names and line numbers are comments AFAIK so they don't matter.

Review of attachment 275577 [details] [review]:

NACK because of the approach.

::: src/Makefile.am
@@ +28,3 @@
+dbusservice_DATA = org.gnome.Maps.service
+
+org.gnome.Maps.service: Makefile

Ah, now I understand your question about PO files. :) We don't want to generate it like this. Check other apps (e.g gnome-boxes) to see how desktop file is generated.

Review of attachment 275577 [details] [review]:

::: src/Makefile.am
@@ +28,3 @@
+dbusservice_DATA = org.gnome.Maps.service
+
+org.gnome.Maps.service: Makefile

This is not the desktop file this is the service file.

I followed the tutorial here:
https://wiki.gnome.org/HowDoI/DBusApplicationLaunching

Which suggested this approach was the best way (doing it from Makefile).

The desktop file is still generated the same way as before, and I think the same way as in boxes. It is just renamed. Since that was what the howto (see above) that I followed said was needed to advertise DBus activable in the desktop file.

(In reply to comment #8)
> The desktop file is still generated the same way as before, and I think the
> same way as in boxes. It is just renamed. Since that was what the howto (see
> above) that I followed said was needed to advertise DBus activable in the
> desktop file.

Ah ok then my comment#5 is valid.

Review of attachment 275577 [details] [review]:

::: src/Makefile.am
@@ +28,3 @@
+dbusservice_DATA = org.gnome.Maps.service
+
+org.gnome.Maps.service: Makefile

Ah ok. ACK then :)

Review of attachment 275578 [details] [review]:

Isn't the actual file renaming missing from this patch?

Review of attachment 275579 [details] [review]:

ACK

Review of attachment 275578 [details] [review]:

Seems bugzilla doesn't pick up on it, if you click the attachment you see:

 .gitignore                                                      | 4 ++--
 configure.ac                                                    | 2 +-
 data/Makefile.am                                                | 4 ++--
 data/gnome-maps.appdata.xml.in                                  | 2 +-
 data/{gnome-maps.desktop.in.in => org.gnome.Maps.desktop.in.in} | 0
 po/POTFILES.in                                                  | 2 +-
 po/POTFILES.skip                                                | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)
 rename data/{gnome-maps.desktop.in.in => org.gnome.Maps.desktop.in.in} (100%)

^^^^

And if you bz apply it the rename takes place.

(In reply to comment #13)
> Review of attachment 275578 [details] [review]:
> 
> Seems bugzilla doesn't pick up on it, if you click the attachment you see:
> 
>  .gitignore                                                      | 4 ++--
>  configure.ac                                                    | 2 +-
>  data/Makefile.am                                                | 4 ++--
>  data/gnome-maps.appdata.xml.in                                  | 2 +-
>  data/{gnome-maps.desktop.in.in => org.gnome.Maps.desktop.in.in} | 0
>  po/POTFILES.in                                                  | 2 +-
>  po/POTFILES.skip                                                | 2 +-
>  7 files changed, 8 insertions(+), 8 deletions(-)
>  rename data/{gnome-maps.desktop.in.in => org.gnome.Maps.desktop.in.in} (100%)
> 
> ^^^^
> 
> And if you bz apply it the rename takes place.

Ah, ACK then.

Attachment 275577 [details] pushed as acfe464 - Make Maps DBus activatable
Attachment 275578 [details] pushed as c9857b6 - Rename desktop file to GApplication application ID
Attachment 275579 [details] pushed as b5fc981 - Advertise DBus activatable status in desktop file