After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729353 - W32: horizontal-buttons get "selected" background when focused
W32: horizontal-buttons get "selected" background when focused
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-01 18:20 UTC by LRN
Modified: 2014-05-01 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
W32: override selected button style to remove colored background (1.00 KB, patch)
2014-05-01 18:20 UTC, LRN
committed Details | Review
Before: horizontal-button has selected background (13.38 KB, image/png)
2014-05-01 18:20 UTC, LRN
  Details
After: horizontal-button does not have selected background (13.37 KB, image/png)
2014-05-01 18:21 UTC, LRN
  Details

Description LRN 2014-05-01 18:20:18 UTC
Some button subclasses (like modelbuttons, when used as horizontal-buttons)
can receive :selected, unlike normal pushbuttons. Need to override the blanket
*:selected { ... } style for them to avoid having "selected" background color.
Comment 1 LRN 2014-05-01 18:20:22 UTC
Created attachment 275566 [details] [review]
W32: override selected button style to remove colored background
Comment 2 LRN 2014-05-01 18:20:52 UTC
Created attachment 275567 [details]
Before: horizontal-button has selected background
Comment 3 LRN 2014-05-01 18:21:28 UTC
Created attachment 275568 [details]
After: horizontal-button does not have selected background
Comment 4 Matthias Clasen 2014-05-01 18:23:17 UTC
Review of attachment 275566 [details] [review]:

ok
Comment 5 LRN 2014-05-01 18:27:30 UTC
Attachment 275566 [details] pushed as 0dd810e - W32: override selected button style to remove colored background