After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729309 - Add support for MPRIS Playlists
Add support for MPRIS Playlists
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal enhancement
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on: 729311 740211
Blocks:
 
 
Reported: 2014-05-01 06:23 UTC by Arnel Borja
Modified: 2014-11-18 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
view: Add method to play a playlist in Playlists view (3.54 KB, patch)
2014-11-16 15:16 UTC, Arnel Borja
none Details | Review
mpris: Implement Playlists interface of MPRIS (7.00 KB, patch)
2014-11-16 15:16 UTC, Arnel Borja
none Details | Review
mpris: Implement Playlists interface of MPRIS (7.00 KB, patch)
2014-11-16 15:39 UTC, Arnel Borja
none Details | Review

Description Arnel Borja 2014-05-01 06:23:25 UTC
It would be nice if we could add support for MPRIS Playlists too, so we don't have to go to the Music window if we want to play a certain playlist.

The specification is here: http://specifications.freedesktop.org/mpris-spec/latest/Playlists_Interface.html

I didn't implement this yet because I'm looking for a good value for Playlist_Id fields. If we use Tracker to save Playlists, we could probably use the tracker:id field for that, just like what we do for songs.
Comment 1 Arnel Borja 2014-11-16 15:16:08 UTC
Created attachment 290794 [details] [review]
view: Add method to play a playlist in Playlists view

Note: Should we show the Playlists view when the user selects a playlist via an MPRIS client? That's how it works in Rhythmbox.
Comment 2 Arnel Borja 2014-11-16 15:16:59 UTC
Created attachment 290795 [details] [review]
mpris: Implement Playlists interface of MPRIS
Comment 3 Arnel Borja 2014-11-16 15:39:19 UTC
Created attachment 290801 [details] [review]
mpris: Implement Playlists interface of MPRIS

Fixed python3-flake8 errors.
Comment 4 Arnel Borja 2014-11-16 15:44:56 UTC
Notes:
* Playlists are only loaded after grilo is 'ready' (Tracker is loaded)
* Playlists are populated into an array since populate is asynchronous while DBus methods and properties are synchronous
* PlaylistChanged is unused since Music doesn't support playlist renaming
* No playlist icons are provided to MPRIS clients
* When there is no active playlist, the object path is undefined, so I just used /org/mpris/MediaPlayer2/Playlist/Invalid similar to NoTrack in TrackList
* The only supported ordering is Alphabetical. Should we support the other orderings? It is possible to support all of the possible orderings except UserDefined but we need additional arrays for each ordering since populate is asynchronous.