Bug 729256 – Busy loop under replace_local_image_links()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 729256 - Busy loop under replace_local_image_links()


Summary:	Busy loop under replace_local_image_links()


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Mailer
Version:	3.10.x (obsolete)
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	evolution-mail-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Duplicates:	730497 (view as bug list)
Depends on:
Blocks:

Reported:	2014-04-30 11:08 UTC by Tomas Popela
Modified:	2014-05-27 06:15 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Proposed patch (3.26 KB, patch) 2014-04-30 11:12 UTC, Tomas Popela	accepted-commit_now	Details \| Review

Description Tomas Popela 2014-04-30 11:08:53 UTC

After opening signature in Edit->Preferences->Composer Preferences->Signatures Evolution ends in busy loop.

Moving from downstream report - https://bugzilla.redhat.com/show_bug.cgi?id=1089107

+ Trace 233536

Thread 1 (Thread 0x7f77d9b1fa80 (LWP 2028))

#0 g_type_check_instance_cast
from /lib64/libgobject-2.0.so.0
#1 WebKit::core(_WebKitDOMElement*)
from /lib64/libwebkitgtk-3.0.so.0
#2 webkit_dom_element_get_next_element_sibling
from /lib64/libwebkitgtk-3.0.so.0
#3 replace_local_image_links
at e-mail-signature-preview.c line 98
#4 replace_local_image_links
at e-mail-signature-preview.c line 99
#5 replace_local_image_links
at e-mail-signature-preview.c line 99
#6 replace_local_image_links
at e-mail-signature-preview.c line 99
#7 replace_local_image_links
at e-mail-signature-preview.c line 99
#8 replace_local_image_links
at e-mail-signature-preview.c line 99
#9 replace_local_image_links
at e-mail-signature-preview.c line 99
#10 replace_local_image_links
at e-mail-signature-preview.c line 99
#11 replace_local_image_links
at e-mail-signature-preview.c line 99
#12 replace_local_image_links
at e-mail-signature-preview.c line 99
#13 replace_local_image_links
at e-mail-signature-preview.c line 99
#14 replace_local_image_links
at e-mail-signature-preview.c line 99
#15 replace_local_image_links
at e-mail-signature-preview.c line 99
#16 replace_local_image_links
at e-mail-signature-preview.c line 99
#17 replace_local_image_links
at e-mail-signature-preview.c line 99
#18 replace_local_image_links
at e-mail-signature-preview.c line 99
#19 replace_local_image_links
at e-mail-signature-preview.c line 99
#20 replace_local_image_links
at e-mail-signature-preview.c line 99
#21 replace_local_image_links
at e-mail-signature-preview.c line 99
#22 replace_local_image_links
at e-mail-signature-preview.c line 99
#23 replace_local_image_links
at e-mail-signature-preview.c line 99
#24 replace_local_image_links
at e-mail-signature-preview.c line 95
#25 replace_local_image_links
at e-mail-signature-preview.c line 99
#26 replace_local_image_links
at e-mail-signature-preview.c line 95
#27 replace_local_image_links
at e-mail-signature-preview.c line 99
#28 replace_local_image_links
at e-mail-signature-preview.c line 95
#29 signature_preview_document_loaded_cb
at e-mail-signature-preview.c line 116
#30 g_closure_invoke
from /lib64/libgobject-2.0.so.0
#31 signal_emit_unlocked_R
from /lib64/libgobject-2.0.so.0
#32 g_signal_emit_valist
from /lib64/libgobject-2.0.so.0
#33 g_signal_emit_by_name
from /lib64/libgobject-2.0.so.0
#34 WebCore::FrameLoader::finishedParsing()
from /lib64/libwebkitgtk-3.0.so.0
#35 WebCore::Document::finishedParsing()
from /lib64/libwebkitgtk-3.0.so.0
#36 WebCore::HTMLDocumentParser::prepareToStopParsing()
from /lib64/libwebkitgtk-3.0.so.0
#37 WebCore::HTMLDocumentParser::finish()
from /lib64/libwebkitgtk-3.0.so.0
#38 WebCore::DocumentWriter::end()
from /lib64/libwebkitgtk-3.0.so.0
#39 WebCore::DocumentLoader::finishedLoading(double)
from /lib64/libwebkitgtk-3.0.so.0
#40 WebCore::DocumentLoader::continueAfterContentPolicy(WebCore::PolicyAction)
from /lib64/libwebkitgtk-3.0.so.0
#41 WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&)
from /lib64/libwebkitgtk-3.0.so.0
#42 WebCore::DocumentLoader::handleSubstituteDataLoadNow(WebCore::Timer<WebCore::DocumentLoader>*)
from /lib64/libwebkitgtk-3.0.so.0
#43 WebCore::ThreadTimers::sharedTimerFiredInternal()
from /lib64/libwebkitgtk-3.0.so.0
#44 WebCore::timeout_cb(void*)
from /lib64/libwebkitgtk-3.0.so.0
#45 g_timeout_dispatch
from /lib64/libglib-2.0.so.0
#46 g_main_context_dispatch
from /lib64/libglib-2.0.so.0
#47 g_main_context_iterate.isra.24
from /lib64/libglib-2.0.so.0
#48 g_main_loop_run
from /lib64/libglib-2.0.so.0
#49 gtk_main
from /lib64/libgtk-3.so.0
#50 main
at main.c line 681

Comment 1 Tomas Popela 2014-04-30 11:12:03 UTC

Created attachment 275481 [details] [review]
Proposed patch

Rework replace_local_image_links to use CSS selectors to avoid iterating through the DOM tree.

Comment 2 Milan Crha 2014-04-30 11:20:11 UTC

Review of attachment 275481 [details] [review]:

Looks good. Please commit to master and 3.12. Thanks.

Comment 3 Tomas Popela 2014-04-30 12:44:54 UTC

Commited into master with [0] and 3.12 with [1]

[0] - https://git.gnome.org/browse/evolution/commit/?id=2ee38c849d96546a1795babf041bd45af37fd3ea

[1] - https://git.gnome.org/browse/evolution/commit/?h=evolution-3-12&id=6dd6e57f36f60053dbbeccca7b1573a2af9e4818

Comment 4 Milan Crha 2014-05-27 06:15:42 UTC

*** Bug 730497 has been marked as a duplicate of this bug. ***