GNOME Bugzilla – Bug 729244
tsdemux: Adds support for ARIB subtitles
Last modified: 2018-11-03 13:23:11 UTC
Created attachment 275469 [details] [review] Adds support for ARIB subtitles In ISDB streams, subtitles are sent as private data and according to ISDB ARIB B10 v4.6 the corresponding descriptor is 0xfd (Data Component descriptor), which has been omitted in GstMpegTsISDBDescriptorType. Here is a patch that adds the support for ARIB subtitles only (described in ARIB STD-B24 v5.2) - once the stream corresponding to the ISDB Data Component Descriptor is identified, we must see in the descriptor's data if the data component id is either 0x0008 - ARIB-Subtitle & teletext coding or 0X0012 - Subtitle coding for digital terrestrial broadcasting (C profile). I thus added a new mime-type "application/x-arib".
Created attachment 275489 [details] [review] Adds support for ARIB subtitles
Hi, Can you split this into two parts: * Add support for ARIB subtitle descriptor parsing in the mpegts-lib (along with support in tests/examples/mpegts/) * Use it in demuxer
Hi, What do you mean by support in tests/examples/mpegts/? Do you want the analysis to go on, once the Data Component Descriptor (0xfd) is identified, in order to distinguish the different types of streams (0x0008 ARIB-Subtitle & teletext coding or 0X0012 -Subtitle coding for digital terrestrial broadcasting etc)? In order to keep the tests/examples/mpegts/ts-parser.c generic, I don't see exactly how should I proceed.
Your ISDB Data Component Descriptor should have a parsing function in mpeg-ts lib. Something like: enum ISDBDataComponentType { ISDB_DATA_COMPONENT_ARIB_XML_BASE_MULTIMEDIA_CODING = 0x0007, ISDB_DATA_COMPONENT_ARIB_SUBTITLE_TELETEXT_CODING = 0x0008, .... }; gboolean gst_mpegts_descriptor_parse_isdb_data_component (const GstMpegTsDescriptor *descriptor, ISDBDataComponentType *data_component_id); And that parsing function should be exposed in the ts-parser example.
Created attachment 278782 [details] [review] Adds support for the ISDB Data component type parsing - branch 1.2 Hi, Here are the patches for the MASTER /1.2 branches for the first part: * Add support for ARIB subtitle descriptor parsing in the mpegts-lib (along with support in tests/examples/mpegts/)
Created attachment 278783 [details] [review] Adds support for the ISDB Data component type parsing - branch MASTER
Comment on attachment 278782 [details] [review] Adds support for the ISDB Data component type parsing - branch 1.2 This is new API, so won't be added to the existing stable branch. It's enough to supply patches against master, thanks.
Created attachment 278822 [details] [review] Adds support for the ISDB Data component type parsing
Created attachment 278823 [details] [review] tsdemux:Adds support for ARIB subtitles Here is the patch for the second part: * Use it in demuxer
Created attachment 279396 [details] [review] Adds support for the ISDB Data component type parsing Updated patch to be conform with the last modifications on MPEGTS.
Created attachment 279397 [details] [review] Adds support for ARIB subtitles Same as above.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/145.