After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729228 - Can't close user location popup
Can't close user location popup
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: map view
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-29 22:47 UTC by Dario Di Nucci
Modified: 2014-06-23 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mapView: Close user location bubble (1.38 KB, patch)
2014-04-29 23:06 UTC, Dario Di Nucci
needs-work Details | Review
mapView: Close user location bubble (1.02 KB, patch)
2014-05-05 08:28 UTC, Dario Di Nucci
committed Details | Review

Description Dario Di Nucci 2014-04-29 22:47:50 UTC
After clicking on the user location marker, it isn't possible to close the bubble with the description.
Comment 1 Dario Di Nucci 2014-04-29 23:06:53 UTC
Created attachment 275459 [details] [review]
mapView: Close user location bubble

New function for unselecting the user location marker.
Bind map clicking with user location marker unselection.
Comment 2 Jonas Danielsson 2014-05-05 07:24:12 UTC
Review of attachment 275459 [details] [review]:

Thanks for the patch! It looks good. Have some comments below.

::: src/mapView.js
@@ +83,1 @@
 

Instead of having a new function I think we can do it like:

    this.view.connect('button-press-event', (function() {
                this._userLocation.setSelected(false);
    }).bind(this));

It feels neater, what do you say? And update the commit log a bit.
Comment 3 Dario Di Nucci 2014-05-05 08:28:43 UTC
Created attachment 275874 [details] [review]
mapView: Close user location bubble

Bind map clicking with user location marker unselection.
Comment 4 Jonas Danielsson 2014-05-06 10:21:15 UTC
Thanks,

thinking more on this I think it belongs in the userLocation module. I will commit this but move it to userLocation.

Really all this should be on the mapLocation but we do not have any general popups yet. We only have them on userLocation, this will change in the future and this code with it. But we can fix this now anyway :)