GNOME Bugzilla – Bug 729228
Can't close user location popup
Last modified: 2014-06-23 09:52:48 UTC
After clicking on the user location marker, it isn't possible to close the bubble with the description.
Created attachment 275459 [details] [review] mapView: Close user location bubble New function for unselecting the user location marker. Bind map clicking with user location marker unselection.
Review of attachment 275459 [details] [review]: Thanks for the patch! It looks good. Have some comments below. ::: src/mapView.js @@ +83,1 @@ Instead of having a new function I think we can do it like: this.view.connect('button-press-event', (function() { this._userLocation.setSelected(false); }).bind(this)); It feels neater, what do you say? And update the commit log a bit.
Created attachment 275874 [details] [review] mapView: Close user location bubble Bind map clicking with user location marker unselection.
Thanks, thinking more on this I think it belongs in the userLocation module. I will commit this but move it to userLocation. Really all this should be on the mapLocation but we do not have any general popups yet. We only have them on userLocation, this will change in the future and this code with it. But we can fix this now anyway :)