GNOME Bugzilla – Bug 729193
cannot add Podcasts without http:// in the url
Last modified: 2014-12-15 09:05:55 UTC
If I would add a podcast like mikrowelle.me/opus.xml, without the http:// at beginning of the url, the following error occour: Podcast Adress is invalid
Can I work on this bug?
(In reply to comment #1) > Can I work on this bug? Of course! Don't hesitate to ask any questions you have.
Created attachment 292704 [details] [review] Fixed by auto-prefixing http:// to the input URL accordingly In the current version the URLs which are not of the form protocol://address are considered as invalid. So in my patch I prefixed http:// before entered URL and checked for the validity of URL.
Hi Ankit, thanks for the patch! It looks good to me. One question before committing to the repository: normally we add the full name of our contributors when we push patches on behalf of them, can you give me your surname then? (It's not mandatory, if you don't want to, just tell me to use the name or nickname instead.) Thanks
Actually my official name is "Ankit" No surname.
Comment on attachment 292704 [details] [review] Fixed by auto-prefixing http:// to the input URL accordingly (In reply to comment #5) > Actually my official name is "Ankit" > > No surname. That's interesting, I thought there were no countries without surnames :) Ankit, I committed your fix, but after I had backported it, I realised that it's not entirely correct, so I'm added a second patch to improve it. The problem with it was this: let's say the user tries to add the URL for a podcast like this: ftp://mikrowelle.me/opus.xml . As you can see, this URL already has a protocol, and what happens is that, the FTP access for that site is closed, so then banshee considers it as not parseable, then with your patch, banshee would test the URL "http://ftp://mikrowelle.me/opus.xml", and then it would tell the user that the URL is wrong. The way to fix this was to not overwrite the feedUri variable in the second call to TryParseUrl().
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Even in India most of the people have surnames. But you can choose to not to have one.
(In reply to comment #6) > (From update of attachment 292704 [details] [review]) > (In reply to comment #5) > > Actually my official name is "Ankit" > > > > No surname. > > That's interesting, I thought there were no countries without surnames :) > > Ankit, I committed your fix, but after I had backported it, I realised that > it's not entirely correct, so I'm added a second patch to improve it. > > The problem with it was this: let's say the user tries to add the URL for a > podcast like this: ftp://mikrowelle.me/opus.xml . As you can see, this URL > already has a protocol, and what happens is that, the FTP access for that site > is closed, so then banshee considers it as not parseable, then with your patch, > banshee would test the URL "http://ftp://mikrowelle.me/opus.xml", and then it > would tell the user that the URL is wrong. > > The way to fix this was to not overwrite the feedUri variable in the second > call to TryParseUrl(). FYI Facebook Thailand lets them enter their names without surname.