After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729181 - user-accounts: Don't leak DateTime instances
user-accounts: Don't leak DateTime instances
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-29 12:21 UTC by Rui Matos
Modified: 2014-05-16 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
user-accounts: Don't leak DateTime instances (1.42 KB, patch)
2014-04-29 12:21 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2014-04-29 12:21:14 UTC
Partially fallout from the header bars.
Comment 1 Rui Matos 2014-04-29 12:21:17 UTC
Created attachment 275419 [details] [review]
user-accounts: Don't leak DateTime instances

Before, we were freeing the DateTime instances when closing the dialog
through the close button and always creating new ones on _show().

Now, with the header bar, we go through the delete-event handler which
just hides the dialog, meaning that we leak the dates instanced on
_show().

Clearing the dates on _show() is more robust anyway. Note that we'd
leak even before switching to a header bar when going through the
delete-event handler.
Comment 2 Bastien Nocera 2014-04-29 12:32:12 UTC
Review of attachment 275419 [details] [review]:

++
Comment 3 Rui Matos 2014-05-16 10:03:24 UTC
Attachment 275419 [details] pushed as 16cd01b - user-accounts: Don't leak DateTime instances