After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729157 - Bill Term discount days are allowed to be more than due days
Bill Term discount days are allowed to be more than due days
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Business
2.6.3
Other Linux
: Normal minor
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-28 23:31 UTC by Michalis
Modified: 2018-06-29 23:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix for function verify_term_ok (2.65 KB, patch)
2014-04-28 23:35 UTC, Michalis 		committed Details | Review

Description Michalis 2014-04-28 23:31:00 UTC 
Although a function was in place to check for that, there was no relevant code. 
I added the code so that discount days are no more than due days (for days) or discount days are no later than due date (for proximo).
Comment 1 Michalis 2014-04-28 23:35:00 UTC 
Created attachment 275393 [details] [review]
fix for function verify_term_ok
Comment 2 Geert Janssens 2014-05-13 10:45:13 UTC 
Comment on attachment 275393 [details] [review]
fix for function verify_term_ok

Thank you for your patch.

I have committed it to the maintenance branch and merged into master.

The only thing I changed in a follow-up commit was to define the error message only once. That avoids potential future translation issues if someone would alter only one of the two strings.

If it was your intention to display a different message for proximo and days type discounts we can revert my change and change the strings accordingly of course.
Comment 3 Geert Janssens 2014-05-13 10:45:28 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 4 John Ralls 2018-06-29 23:30:30 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=729157. Please update any external references or bookmarks.