After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729122 - Express installation broken for win7 on en_GB
Express installation broken for win7 on en_GB
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on: 729253
Blocks:
 
 
Reported: 2014-04-28 15:56 UTC by Zeeshan Ali
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media-manager: Fetch languages from Tracker (3.84 KB, patch)
2014-04-30 11:17 UTC, Zeeshan Ali
committed Details | Review
media-manager: Use correct tracker language property (1.15 KB, patch)
2014-05-08 13:29 UTC, Zeeshan Ali
none Details | Review
media-manager: Use correct tracker language property (7.36 KB, patch)
2014-05-20 15:18 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2014-04-28 15:56:21 UTC
Firstly this only applies to medias that are provided by Tracker. What happens is that supported languages are currently only exposed by libosinfo if you ask it to detect the media and we don't do that for such medias as Tracker has already detected all essential info for us.

While the short term solution would be to run detection on such medias as well, the proper solution would be to hack Tracker to extract and expose language info (bug#729121) and then make use of that in Boxes.
Comment 1 Zeeshan Ali 2014-04-30 11:17:36 UTC
Created attachment 275483 [details] [review]
media-manager: Fetch languages from Tracker

Fetch list of supported languages for each ISO file from Tracker.
Comment 2 Zeeshan Ali 2014-04-30 17:28:25 UTC
Comment on attachment 275483 [details] [review]
media-manager: Fetch languages from Tracker

This patch doesn't exactly need the tracker changes so I'm pushing it already. Turns out the actual issue is win7-specific so solution will have to be in libosinfo.

Attachment 275483 [details] pushed as 869c1d4 - media-manager: Fetch languages from Tracker
Comment 3 Zeeshan Ali 2014-05-08 13:29:55 UTC
Created attachment 276159 [details] [review]
media-manager: Use correct tracker language property

In the end, it was decided not to make the existing 'nie:language'
property multi-valued but rather introduce a new custom property for
this case, 'osinfo:language'.
Comment 4 Zeeshan Ali 2014-05-20 15:18:42 UTC
Created attachment 276876 [details] [review]
media-manager: Use correct tracker language property

In the end, it was decided not to make the existing 'nie:language'
property multi-valued but rather introduce a new custom property for
this case, 'osinfo:language'.

This patch also:

* moves the handling of Tracker SPARQL query into a seperate
  module/class, TrackerISOQuery.

* ensures compatibility with older Tracker (that doesn't extract and
  expose the new 'osinfo:language' property) by using different queries,
  depending on whether or not 'osinfo:language' property is known to
  Tracker.

* ensures language info is extracted from media if its available in case
  of older Tracker and therefore ensures that we don't end up using a
  locale that media doesn't support and break express installation.
Comment 5 Zeeshan Ali 2014-05-20 15:19:50 UTC
Attachment 276876 [details] pushed as 348da74 - media-manager: Use correct tracker language property