After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729096 - Media art is not shown in MPRIS clients
Media art is not shown in MPRIS clients
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: 3.14
Assigned To: Arnel Borja
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-28 10:32 UTC by Arnel Borja
Modified: 2014-04-28 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mpris: Fix some typos (1.05 KB, patch)
2014-04-28 10:38 UTC, Arnel Borja
accepted-commit_now Details | Review
albumArtCache: Update thumbnail after lookup (1.85 KB, patch)
2014-04-28 10:38 UTC, Arnel Borja
none Details | Review

Description Arnel Borja 2014-04-28 10:32:22 UTC
Since the refactoring of albumArtCache.py, album art is no longer shown in MPRIS clients. This happens because of a typo in mpris.py and the thumbnail is no longer updated in albumArtCache.py.
Comment 1 Arnel Borja 2014-04-28 10:38:07 UTC
Created attachment 275314 [details] [review]
mpris: Fix some typos

Wrong variables are being checked, which prevents the next lines to be
executed.
Comment 2 Arnel Borja 2014-04-28 10:38:49 UTC
Created attachment 275315 [details] [review]
albumArtCache: Update thumbnail after lookup

Update the thumbnail property of items so that we do the lookup only
once. This also allows MPRIS to get the URI of the media art.
Comment 3 Vadim Rutkovsky 2014-04-28 10:40:34 UTC
Review of attachment 275314 [details] [review]:

Looks good
Comment 4 Vadim Rutkovsky 2014-04-28 11:59:17 UTC
Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=306eadb