Bug 728984 – adwaita-icon-theme throws many warnings during the build

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 728984 - adwaita-icon-theme throws many warnings during the build


Summary:	adwaita-icon-theme throws many warnings during the build


Status:	RESOLVED FIXED

Product:	adwaita-icon-theme
Classification:	Core
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Jakub Steiner
QA Contact:	Jakub Steiner

URL:
Whiteboard:

Duplicates:	729998 (view as bug list)
Depends on:
Blocks:

Reported:	2014-04-25 21:39 UTC by Vadim Rutkovsky
Modified:	2014-06-19 09:58 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Drop legacy icon name mapping (2.61 KB, patch) 2014-05-28 15:22 UTC, Matthias Clasen	none	Details \| Review
Drop legacy icon name mapping (2.69 KB, patch) 2014-05-28 15:30 UTC, Matthias Clasen	committed	Details \| Review

Description Vadim Rutkovsky 2014-04-25 21:39:23 UTC

Gnome-icon-themes cannot be built at revision https://git.gnome.org/browse/adwaita-icon-theme/commit/?id=14a072fa37bbe9244eb4d0bd0fd469eb934b13d4, see the build log at http://build.gnome.org/continuous/buildmaster/builds/2014/04/25/43/build/log-gnome-icon-theme.txt

After the bug is fixed please revert https://git.gnome.org/browse/gnome-continuous/commit/?id=520f262b81a5f0c0482e3fd59f39abeee57cf60c

Comment 1 Vadim Rutkovsky 2014-04-26 15:27:05 UTC

Apparently adwaita-icon-theme builds correctly, though build log is flooded with warnings like:
Setting up icon mapping for: mimetypes
Traceback (most recent call last):

+ Trace 233526

File "/usr/libexec/icon-name-mapping", line 58 in <module>
```
make_icon_links(icon, '.png')
```
File "/usr/libexec/icon-name-mapping", line 38 in make_icon_links
```
icon_name = icon_node['name']
```
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 266 in __getitem__
```
return self._children[index]
```

TypeError: list indices must be integers, not str

Comment 2 Matthias Clasen 2014-05-28 15:22:05 UTC

Created attachment 277396 [details] [review]
Drop legacy icon name mapping

The switch gnome -> Adwaita is the perfect opportunity to do
this cleanup. Also, the icon name mapping tool doesn't work.

Comment 3 Matthias Clasen 2014-05-28 15:30:02 UTC

Created attachment 277397 [details] [review]
Drop legacy icon name mapping

The switch gnome -> Adwaita is the perfect opportunity to do
this cleanup. Also, the icon name mapping tool doesn't work.

Comment 4 Matthias Clasen 2014-05-28 15:30:40 UTC

Attachment 277397 [details] pushed as 52330b9 - Drop legacy icon name mapping

Comment 5 Jakub Steiner 2014-06-19 09:58:24 UTC

*** Bug 729998 has been marked as a duplicate of this bug. ***