After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728962 - Add audiosink elements to support raw and ac3/dts passthrough on the RPI
Add audiosink elements to support raw and ac3/dts passthrough on the RPI
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-25 16:59 UTC by Josep Torra Valles
Modified: 2014-07-23 08:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
omxaudiosink: Implements OpenMAX based audio sinks (52.44 KB, patch)
2014-04-25 16:59 UTC, Josep Torra Valles
none Details | Review
omxaudiosink: Implements OpenMAX based audio sinks (53.20 KB, patch)
2014-04-25 18:44 UTC, Josep Torra Valles
none Details | Review
omxaudiosink: Implements OpenMAX based audio sinks (53.20 KB, patch)
2014-05-09 07:52 UTC, Josep Torra Valles
committed Details | Review

Description Josep Torra Valles 2014-04-25 16:59:10 UTC
Created attachment 275150 [details] [review]
omxaudiosink: Implements OpenMAX based audio sinks

The provided patch adds audiosink feature to render audio using OpenMax.

It has been developed and tested on the RPI and provides support for raw audio on omxanalogaudiosink and raw + ac3/dts passthrough on omxhdmisink.
Comment 1 Josep Torra Valles 2014-04-25 18:44:52 UTC
Created attachment 275155 [details] [review]
omxaudiosink: Implements OpenMAX based audio sinks

Amend the commit message to reflect this bug# and describe some more the capabilities provided.
Comment 2 Josep Torra Valles 2014-05-09 07:52:46 UTC
Created attachment 276214 [details] [review]
omxaudiosink: Implements OpenMAX based audio sinks

Rebased to latest master
Comment 3 Josep Torra Valles 2014-05-09 12:27:30 UTC
Commit: b3eb4d897d83713d858839ebd8b01bad510e13b0
URL:    http://cgit.freedesktop.org/gstreamer/gst-omx/commit/?id=b3eb4d897d83713d858839ebd8b01bad510e13b0

Author: Josep Torra <n770galaxy@gmail.com>
Date:   Fri Apr  4 14:11:58 2014 +0200

omxaudiosink: Implements OpenMAX based audio sinks

Provides omxanalogaudiosink and omxhdmiaudiosink elements on
the Raspberry PI.

- omxanalogaudiosink is capable to render raw mono or stereo audio
through the jack output.
- omxhdmiaudiosink is capable to render raw audio up to 8 channels
and transmit ac3/dts(IEC 61937) through the HDMI output.
- sinks provide a clock derived from rendered samples
- sinks support the GstStreamVolume interface by implementing
the volume and mute properties.

https://bugzilla.gnome.org/show_bug.cgi?id=728962

---
Comment 4 Sebastian Dröge (slomo) 2014-05-10 20:49:54 UTC
This currently breaks compilation on all other targets than the RPi:

gstomxaudiosink.c:897:7: error: use of undeclared identifier
      'OMX_IndexConfigAudioRenderingLatency'; did you mean
      'OMX_IndexConfigAudioReverberation'?
      OMX_IndexConfigAudioRenderingLatency, &param);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 5 Josep Torra Valles 2014-05-12 10:42:48 UTC
Build breakage fixed in the following commit.

Commit: e08540d969c170a37425b07b8e5b97b2bfbf880a
URL:    http://cgit.freedesktop.org/gstreamer/gst-omx/commit/?id=e08540d969c170a37425b07b8e5b97b2bfbf880a

Author: Josep Torra <n770galaxy@gmail.com>
Date:   Mon May 12 12:33:32 2014 +0200

omxaudiosink: implement _delay only in the RaspberryPI

Make code implementation conditionally built for RaspberryPI because
OMX_IndexConfigAudioRenderingLatency seems to be a Broadcom extension.

On other targets the query position might not be accurate without
implementing _delay appropriatelly.