After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728888 - gssdp-socket-source: Fix the destroy/unref order on a GSource
gssdp-socket-source: Fix the destroy/unref order on a GSource
Status: RESOLVED FIXED
Product: gssdp
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-24 15:59 UTC by Philip Withnall
Modified: 2019-02-22 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gssdp-socket-source: Fix the destroy/unref order on a GSource (1.00 KB, patch)
2014-04-24 15:59 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-04-24 15:59:18 UTC 
This fixes a potential crash when calling g_source_destroy() on an already-freed GSource.
Comment 1 Philip Withnall 2014-04-24 15:59:20 UTC 
Created attachment 275063 [details] [review]
gssdp-socket-source: Fix the destroy/unref order on a GSource

g_source_destroy() should always be called before g_source_unref().
Comment 2 Jens Georg 2014-04-25 06:47:47 UTC 
Review of attachment 275063 [details] [review]:

+1
Comment 3 Philip Withnall 2014-04-25 07:40:15 UTC 
Attachment 275063 [details] pushed as 50cd3e9 - gssdp-socket-source: Fix the destroy/unref order on a GSource