After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728877 - Support for PicasaWeb
Support for PicasaWeb
Product: gnome-online-accounts
Classification: Core
Component: general
Other All
: Normal enhancement
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks: 711563 728878
Reported: 2014-04-24 13:09 UTC by Saurav Agarwalla
Modified: 2014-05-19 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Add support for PicasaWeb (5.28 KB, patch)
2014-05-19 10:00 UTC, Saurav Agarwalla
none Details | Review
Add support for PicasaWeb (5.26 KB, patch)
2014-05-19 10:11 UTC, Saurav Agarwalla
needs-work Details | Review
Add support for PicasaWeb (5.19 KB, patch)
2014-05-19 14:16 UTC, Saurav Agarwalla
committed Details | Review
Correct the indentation (913 bytes, patch)
2014-05-19 14:17 UTC, Saurav Agarwalla
needs-work Details | Review
google: Replace tabs with spaces (968 bytes, patch)
2014-05-19 15:04 UTC, Debarshi Ray
committed Details | Review

Description Saurav Agarwalla 2014-04-24 13:09:23 UTC
I'm working on the PicasaWeb support for GNOME Photos and I will use GOA for authorizations. This bug report will involve changes I need to make for the same.
Comment 1 Saurav Agarwalla 2014-05-19 10:00:09 UTC
Created attachment 276752 [details] [review]
Add support for PicasaWeb

Added support for PicasaWeb. Please let me know what you think. Thanks.
Comment 2 Saurav Agarwalla 2014-05-19 10:11:05 UTC
Created attachment 276755 [details] [review]
Add support for PicasaWeb

Left a newline in the earlier patch by mistake. Corrected it here.
Comment 3 Debarshi Ray 2014-05-19 13:02:58 UTC
Review of attachment 276755 [details] [review]:

Thanks for the patch, Saurav. Looks very good apart from two minor things.

::: src/goabackend/goagoogleprovider.c
@@ +144,3 @@
+         /* Google Cloud Print */
+         " "

This is an unrelated change. White-space changes like these are best done in a separate patch. Otherwise they are misleading. Can you please put it in a separate patch?

@@ +616,3 @@
+                                                   "photos-disabled",
+                                                   _("Pho_tos"));

The mnemonic for "Photos" is "P" in Flickr and Facebook. Maybe we should do the same here and change the mnemonic for "Printers", which is a relatively new member of the family and not yet widely used? Food for thought.
Comment 4 Saurav Agarwalla 2014-05-19 14:16:37 UTC
Created attachment 276783 [details] [review]
Add support for PicasaWeb

Made the changes. Changed the mnemonic for "Printers" to 't' and made 'P' the mnemonic for "Photos".
Comment 5 Saurav Agarwalla 2014-05-19 14:17:53 UTC
Created attachment 276784 [details] [review]
Correct the indentation
Comment 6 Debarshi Ray 2014-05-19 15:00:11 UTC
Review of attachment 276783 [details] [review]:

Perfect. I took the liberty to add to README.
Comment 7 Debarshi Ray 2014-05-19 15:04:01 UTC
Review of attachment 276784 [details] [review]:

Good catch. You are missing a reference to this bug in the commit message.
Comment 8 Debarshi Ray 2014-05-19 15:04:50 UTC
Created attachment 276787 [details] [review]
google: Replace tabs with spaces

Added the URL to this bug.
Comment 9 Debarshi Ray 2014-05-19 15:05:24 UTC
Thanks for working on this, Saurav.