After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728871 - gssdp-client: Use g_warning() instead of g_error()
gssdp-client: Use g_warning() instead of g_error()
Status: RESOLVED FIXED
Product: gssdp
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-24 12:00 UTC by Philip Withnall
Modified: 2019-02-22 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gssdp-client: Use g_warning() instead of g_error() (1.23 KB, patch)
2014-04-24 12:00 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-04-24 12:00:41 UTC 
A minor change, but important for prevent client abort()s in conditions which cause hostname resolution to fail. In this particular case, the FD limit had been reached.
Comment 1 Philip Withnall 2014-04-24 12:00:43 UTC 
Created attachment 275051 [details] [review]
gssdp-client: Use g_warning() instead of g_error()

get_host_ip() can gracefully fail, and all the code which calls it can
handle graceful failure. There’s no need for a non-graceful failure
using g_error(), which will just cause unnecessary abort()s in client
applications.
Comment 2 Jens Georg 2014-04-25 06:45:40 UTC 
Review of attachment 275051 [details] [review]:

+1, some left-over I assume
Comment 3 Philip Withnall 2014-04-25 07:40:03 UTC 
Attachment 275051 [details] pushed as 468e985 - gssdp-client: Use g_warning() instead of g_error()