GNOME Bugzilla – Bug 728865
auto-move-windows: Various improvements to checkWorkspaces() replacement
Last modified: 2014-04-24 17:17:10 UTC
The replacement started out just removing empty workspaces at the end, but over time, it diverged significantly from the core shell version.
Created attachment 275039 [details] [review] auto-move-windows: Move check for dynamic workspaces Move the check into checkWorkspaces rather than replacing the function conditionally, to handle changes to the setting.
Created attachment 275040 [details] [review] auto-move-windows: Respect keep-alive flag in checkWorkspaces
Created attachment 275041 [details] [review] auto-move-windows: Take workspaces in startup sequences into account See https://bugzilla.gnome.org/show_bug.cgi?id=664202 for the corresponding patch in core shell.
Created attachment 275042 [details] [review] auto-move-windows: Never show the overview after removing workspace This follows the core shell behavior, where we stopped doing this a while ago.
Created attachment 275043 [details] [review] auto-move-windows: Never remove the active workspace Follow core shell in never removing the active workspace.
Review of attachment 275039 [details] [review]: Definitely.
Review of attachment 275040 [details] [review]: Ok
Review of attachment 275041 [details] [review]: Yes.
Review of attachment 275042 [details] [review]: Right.
Review of attachment 275043 [details] [review]: And right.
Attachment 275039 [details] pushed as c8b67cb - auto-move-windows: Move check for dynamic workspaces Attachment 275040 [details] pushed as 7f008aa - auto-move-windows: Respect keep-alive flag in checkWorkspaces Attachment 275041 [details] pushed as c005393 - auto-move-windows: Take workspaces in startup sequences into account Attachment 275042 [details] pushed as d9b543c - auto-move-windows: Never show the overview after removing workspace Attachment 275043 [details] pushed as 80f49c2 - auto-move-windows: Never remove the active workspace