After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728841 - XML backend does not always store KVP slots
XML backend does not always store KVP slots
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Backend - XML
git-master
Other All
: Normal normal
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-24 02:13 UTC by Michalis
Modified: 2018-06-29 23:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against maint tree (7.28 KB, patch)
2014-04-24 04:23 UTC, Michalis 		committed Details | Review

Description Michalis 2014-04-24 02:13:59 UTC 
A new bug was discovered from enhancement request 728136. 
XML backend for address, entry, job, order, taxtable does not save KVP.
Comment 1 Michalis 2014-04-24 04:23:42 UTC 
Created attachment 275019 [details] [review]
Patch against maint tree
Comment 2 Geert Janssens 2014-04-24 10:32:25 UTC 
Comment on attachment 275019 [details] [review]
Patch against maint tree

Thank you for the patch! I have committed it to maint and master.
Additionally I have implemented the safeguard as discussed in bug 728136.
Comment 3 Michalis 2014-04-24 15:46:47 UTC 
Hi Geert,
I think you didn't modify gncOrder.c for gncOrderCommitEdit to implement the safeguard.
Comment 4 Geert Janssens 2014-04-24 16:17:56 UTC 
Michalis, it pleases me that you proofread my follow-up commit, really :)

I haven't forgotten about gncOrder. I deliberately omitted it. My motivation is that orders are not fully implemented right now. If they ever will, they will no doubt get their own feature code to prevent older gnucash versions from loading data files with orders in them. That feature code would then automatically prevent accidental loading of orders with kvp values.

For all the other objects you spotted this doesn't hold true. These objects are in active use already and hence there won't be a broad feature tag for these objects. As such these needed a specific restriction on the kvp part only.
Comment 5 Michalis 2014-04-24 17:17:08 UTC 
I didn't think of it that way, and of course you're right. 
By the way, I wasn't proofreading your code, I was just trying to make sure I have the latest master code after my checkout and decided to check on gncOrder (have no idea why :) )
Comment 6 John Ralls 2018-06-29 23:30:18 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=728841. Please update any external references or bookmarks.