After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728808 - W32: Checkboxes on modelbuttons are drawn like buttons themselves
W32: Checkboxes on modelbuttons are drawn like buttons themselves
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-04-23 16:42 UTC by LRN
Modified: 2014-04-24 03:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
W32: Add a set of "focused" styles to checkmarks (2.07 KB, patch)
2014-04-23 16:42 UTC, LRN
committed Details | Review
Before: checkmark is drawn as if it were a button (5.04 KB, image/png)
2014-04-23 16:43 UTC, LRN
  Details
After: checkmark is drawn normally (5.05 KB, image/png)
2014-04-23 16:44 UTC, LRN
  Details

Description LRN 2014-04-23 16:42:34 UTC
I guess this is because modelbuttons propagate styles to their children
in a different way.
Comment 1 LRN 2014-04-23 16:42:39 UTC
Created attachment 274966 [details] [review]
W32: Add a set of "focused" styles to checkmarks

This prevents checkmarks in modelbuttons from being styled as buttons
(apparently, modelbuttons apply "focused" to their children, unlike
normal buttons).
Comment 2 LRN 2014-04-23 16:43:41 UTC
Created attachment 274967 [details]
Before: checkmark is drawn as if it were a button
Comment 3 LRN 2014-04-23 16:44:17 UTC
Created attachment 274968 [details]
After: checkmark is drawn normally
Comment 4 Matthias Clasen 2014-04-24 03:23:04 UTC
Review of attachment 274966 [details] [review]:

ok
Comment 5 LRN 2014-04-24 03:41:59 UTC
Attachment 274966 [details] pushed as 1bcd7c4 - W32: Add a set of "focused" styles to checkmarks