GNOME Bugzilla – Bug 728805
tsdemux: always conciders mpeg audio ADTS as mpegversion=2
Last modified: 2018-11-03 13:22:45 UTC
According to tsdemux code, mpeg audio with stream-format=adts will always have mpegversion=2, but aacparse says it can also be mpegversion=4. For example, on that file: https://dl.dropboxusercontent.com/u/2804070/tron_en_ge_aac_h264.ts tsdemux conciders the stream as being mpegversion=2 but aacparse will change that to being mpegversion=4. It will not cause much issue in practice but running gst-discoverer on that sample will tell us that the file contains 4 audio tracks 2 with mpegtsversion=2 and 2 other with 4 which is clearly wrong. I am attaching a patch where we just do not set the version at the demuxer level and let the parser do it, I am not sure it is really correct but as parser are now mandatory it works. Otherwize we should just parse further in the demuxer to get that info.
Created attachment 274959 [details] [review] tsdemux: Let the parser set the megversion of audio/mpeg In the case of stream-format=adts as it can be both mpegversion=2 or mpegversion=4 and we do not have the information right away
Comment on attachment 274959 [details] [review] tsdemux: Let the parser set the megversion of audio/mpeg This patch does not make sense.
right now this bug is a pitfall for my application, so *bump* are you still working on a patch, thibault?
I do not no, you are very welcome to have a look yourself :)
I also have a problem with mpegversion while transmuxing UDP TS to MP4. What were the downsides of your proposed patch ? Otherwise, a parsing is needed in tsdemux to properly set mpegversion.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/142.