After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728805 - tsdemux: always conciders mpeg audio ADTS as mpegversion=2
tsdemux: always conciders mpeg audio ADTS as mpegversion=2
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-23 16:19 UTC by Thibault Saunier
Modified: 2018-11-03 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tsdemux: Let the parser set the megversion of audio/mpeg (1.05 KB, patch)
2014-04-23 16:20 UTC, Thibault Saunier
rejected Details | Review

Description Thibault Saunier 2014-04-23 16:19:30 UTC
According to tsdemux code, mpeg audio with stream-format=adts will always have mpegversion=2, but aacparse says it can also be mpegversion=4.

For example, on that file: https://dl.dropboxusercontent.com/u/2804070/tron_en_ge_aac_h264.ts tsdemux conciders the stream as being mpegversion=2 but aacparse will change that to being mpegversion=4.

It will not cause much issue in practice but running gst-discoverer on that sample will tell us that the file contains 4 audio tracks 2 with mpegtsversion=2 and 2 other with 4 which is clearly wrong.

I am attaching a patch where we just do not set the version at the demuxer level and let the parser do it, I am not sure it is really correct but as parser are now mandatory it works.

Otherwize we should just parse further in the demuxer to get that info.
Comment 1 Thibault Saunier 2014-04-23 16:20:03 UTC
Created attachment 274959 [details] [review]
tsdemux: Let the parser set the megversion of audio/mpeg

In the case of stream-format=adts as it can be both mpegversion=2 or
mpegversion=4 and we do not have the information right away
Comment 2 Thibault Saunier 2014-04-24 10:05:11 UTC
Comment on attachment 274959 [details] [review]
tsdemux: Let the parser set the megversion of audio/mpeg

This patch does not make sense.
Comment 3 Andreas Frisch 2015-02-04 22:16:54 UTC
right now this bug is a pitfall for my application, so *bump*
are you still working on a patch, thibault?
Comment 4 Thibault Saunier 2015-02-05 08:20:33 UTC
I do not no, you are very welcome to have a look yourself :)
Comment 5 Gaylord CHARLES 2018-09-27 12:57:14 UTC
I also have a problem with mpegversion while transmuxing UDP TS to MP4.
What were the downsides of your proposed patch ?

Otherwise, a parsing is needed in tsdemux to properly set mpegversion.
Comment 6 GStreamer system administrator 2018-11-03 13:22:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/142.