After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728794 - Use headerbar in the bookmarks dialog
Use headerbar in the bookmarks dialog
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-23 13:58 UTC by Yosef Or Boczko
Modified: 2014-04-23 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bookmarks-window: Use headerbar as the titlebar (1.29 KB, patch)
2014-04-23 14:01 UTC, Yosef Or Boczko
committed Details | Review

Description Yosef Or Boczko 2014-04-23 13:58:19 UTC
In the patch I set the type hint of the bookmarks window as
GDK_WINDOW_TYPE_HINT_DIALOG because we don't want
to see the fallback app menu in the headerbar of the bookmarks window.
Comment 1 Yosef Or Boczko 2014-04-23 14:01:22 UTC
Created attachment 274955 [details] [review]
bookmarks-window: Use headerbar as the titlebar
Comment 2 Cosimo Cecchi 2014-04-23 16:25:58 UTC
Review of attachment 274955 [details] [review]:

Looks good
Comment 3 Yosef Or Boczko 2014-04-23 16:53:29 UTC
Review of attachment 274955 [details] [review]:

Pushed as 6aaf0c6 - bookmarks-window: Use headerbar as the titlebar