After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728760 - Add Ctrl+L Goto Page shortcut to docs
Add Ctrl+L Goto Page shortcut to docs
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: User documentation
unspecified
Other All
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
Evince Maintainers
gnomeasia, winterdocs
Depends on:
Blocks:
 
 
Reported: 2014-04-22 22:20 UTC by Hashem Nasarat
Modified: 2015-08-11 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Ctrl+L Goto Page shortcut to docs (1.06 KB, patch)
2014-04-22 22:20 UTC, Hashem Nasarat
none Details | Review
patch (1.49 KB, patch)
2015-05-11 16:55 UTC, Kat
committed Details | Review

Description Hashem Nasarat 2014-04-22 22:20:17 UTC
Somebody asked about this shortcut on IRC and it's quite unfortunate
to have to go into the source to find out what it is.

Once the API for https://wiki.gnome.org/Design/OS/HelpOverlay are
finished, we won't need to keep the docs in sync with the shortcuts.
Comment 1 Hashem Nasarat 2014-04-22 22:20:18 UTC
Created attachment 274913 [details] [review]
Add Ctrl+L Goto Page shortcut to docs
Comment 2 Germán Poo-Caamaño 2014-05-01 23:27:51 UTC
Review of attachment 274913 [details] [review]:

This patch looks good to me.
Comment 3 Kat 2014-05-02 07:38:00 UTC
Review of attachment 274913 [details] [review]:

::: help/C/shortcuts.page
@@ +94,3 @@
     </tr>
+    <tr>
+        <td><p>Go to a specific page number.</p></td>

Do you think it might be a good idea to tell the user that they need to specify the page number?
Comment 4 pramiti 2014-06-11 14:25:32 UTC
I am trying to use Ctrl+ l to go to  specfic page. But no dialogue box appears.
Comment 5 Shobha 2014-06-11 16:46:47 UTC
(In reply to comment #4)
> I am trying to use Ctrl+ l to go to  specfic page. But no dialogue box appears.

Actually, no dialog box appears you have edit the page number as by pressing Ctrl+L the current page number gets highlighted in the "Select Page" on the toolbar :)
Comment 6 pramiti 2014-06-11 20:41:56 UTC
I am trying to use Ctrl+ l to go to  specfic page. But no dialogue box appears.
Comment 7 Germán Poo-Caamaño 2014-06-11 20:56:00 UTC
(In reply to comment #6)
> I am trying to use Ctrl+ l to go to  specfic page. But no dialogue box appears.

This bug report is about the documentation of this feature, not about support.  At least you have an specific bug, in which case, it should be reported in a different bug.  Also, you must mention which version of Evince you are using.

In newest versions, Ctrl+L does not bring any new dialog.  When you press Ctrl+L, it brings the focus to the page number in the toolbar, there you write the page number and press Enter.
Comment 8 Kat 2015-05-11 16:55:34 UTC
Created attachment 303227 [details] [review]
patch

Patch which gives a fuller set of instructions. Ready to push to master in my opinion, I just can't do it myself at the moment.
Comment 9 Ben Gamari 2015-08-10 08:29:19 UTC
Can someone please push this?
Comment 10 Kat 2015-08-11 09:44:30 UTC
Comment on attachment 303227 [details] [review]
patch

Pushed to master in commit fc384675d5b29ac1edd20e1202a587d95f164b52