GNOME Bugzilla – Bug 728756
Scrollbar is overriding area behind within popover
Last modified: 2017-10-27 14:33:29 UTC
Created attachment 274912 [details] Popover Not sure if it's a GTK+ popover bug itself. Please see attached screenshot.
I'm not seeing this here. Are you using Ubuntu for a chance? As far as I know, they still patch GTK+ for their "overlay scrollbars", in which case I guess that's expected behavior ...
Archlinux. It doesn't look patched: https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/gtk3 I'll try some VMs later on.
Nah, Arch generally follows upstream closely, so this should indeed be our bug. However I'm still not reproducing the issue (neither with the normal nor the dark theme variant) - what locale are you using?
Yeah, you are right. It's a locale-related bug. It works fine with C locale. LANG=uk_UA.UTF-8 polari
Redirected to gtk+. Re-reproduced with 3.12.2.
I'm not sure there's a bug here, really. With overlay scrollbars this is just what happens when you put your controls too close to the edge. Not sure it is much of a problem in the polari user list case, since the entire row acts as the toggle. The arrow is just the indicator. Moving this back to polari.
The newcomer keyword is added to this bug. To clarify what is needed here, probably this bug can probably be fixed by adding spacing to the right of the arrow in the user list.
Created attachment 345482 [details] [review] patch to increase right margin on username box I am new to GNOME contribution so please let me know if I'm not doing this correctly. This patch should prevent the overlay scrollbars from laying on top of the arrow in the username boxes.
Review of attachment 345482 [details] [review]: Thanks for the patch! As noted below, unfortunately the patch will not work as intended in all cases, so marking as needs-work. As an additional nit: Commit messages should follow the form outlined in https://chris.beams.io/posts/git-commit/#seven-rules, so something like: userList: Increase right margin in userlist box When overlay scrollbars are used, they'll currently cover parts of the contents when expanded. Increase the margin to avoid this. ::: src/userList.js @@ +470,3 @@ this.add(vbox); + let hbox = new Gtk.Box({ margin_right: 12, This assumes the scroll bar is located on the right, which is not the case in locales with a text direction from right-to-left (as Arabic or Hebrew).
Created attachment 362415 [details] [review] userList: Increase right margin of row headers Updated patch to use margin-end instead of margin-right (to account for both left-to-right and right-to-left locales) and slightly changed the commit message.
Attachment 362415 [details] pushed as 1f11373 - userList: Increase right margin of row headers