After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728743 - make test fails
make test fails
Status: RESOLVED FIXED
Product: easytag
Classification: Other
Component: general
2.2.x
Other Linux
: Normal normal
: 2.2
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-22 17:57 UTC by Ivan Larionov
Modified: 2014-04-22 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configuration log (54.64 KB, text/x-log)
2014-04-22 17:57 UTC, Ivan Larionov 		Details

Description Ivan Larionov 2014-04-22 17:57:16 UTC 
$ make test
TEST: tests/test-scan... (pid=17033)
  /scan/underscore-to-space:                                           OK
  /scan/remove-space:                                                  OK
  /scan/P20-to-space:                                                  **
ERROR:tests/test-scan.c:33:check_string: assertion failed (string1 == string2): ("S T R020" == "S T R ")
FAIL
GTester: last random seed: R02Sd61531c3fcfc646443577093071ac115
make: *** [test] Terminated
Comment 1 Ivan Larionov 2014-04-22 17:57:54 UTC 
Created attachment 274900 [details]
configuration log
Comment 2 David King 2014-04-22 18:31:27 UTC 
I cannot reproduce the test failure. However, I guess that this is because the arguments to strcpy() in Scan_Convert_P20_Into_Space() overlap, which leads to undefined behaviour. Can you revert 553ba87d0311e4e4c64f2321b5aa654df0c4ae29 (which was added in bug 726108) and see if that fixes the test?

https://git.gnome.org/browse/easytag/commit/?id=553ba87d0311e4e4c64f2321b5aa654df0c4ae29
Comment 3 Ivan Larionov 2014-04-22 18:34:19 UTC 
Yes, reverting of 553ba87d0311e4e4c64f2321b5aa654df0c4ae29 fixes this problem for me.
Comment 4 David King 2014-04-22 18:40:07 UTC 
Thanks for the confirmation. I have reverted the problematic patch on the easytag-2-2 and master branches. The fix will be in an upcoming 2.2.1 release, due in the next few days.
Comment 5 Ivan Larionov 2014-04-22 18:42:18 UTC 
Great, thank you for such fast fix!