GNOME Bugzilla – Bug 728670
remove margins in the “add to folder” window (?)
Last modified: 2015-09-28 08:30:58 UTC
Created attachment 274826 [details] the cursor is on the right margin The “add to folder” popup window displays a list of app’ folders, and if needed a scrollbar, with around margins. I find these margins unaesthetic, because we have in background the main window of Software with the same type of design (a headerbar, a list of things and a scrollbar) without any border. Shouldn’t they be removed? --- Thinking loud: and shouldn’t the “ckecked” mark (« ✔ ») be at the left?
lets hear what the designers say
Good call, Arnaud. This is actually what we recommend (against our own previous practice) in the new HIG: https://developer.gnome.org/hig/stable/lists.html.en
We have a similar situation in: - the list of Software Sources + list of the pieces of software from each source; - the list of the OS Updates. What all these windows have in common is that they are dialog boxes containing a list box and almost nothing else. The margins could be removed. (In reply to comment #0) > --- > Thinking loud: and shouldn’t the “ckecked” mark (« ✔ ») be at the left? It could be at left, right, or whatever the designers prefer as long as it is consistent. But from the pictures in the HIG it seems to me that the texts in the list should be left-aligned and the check marks should be right-aligned while in the "Add to folder" popup the app folder names are centered and the check marks are left-aligned. Allan, what do you think?
(In reply to Rafal Luzynski from comment #3) > We have a similar situation in: > - the list of Software Sources + list of the pieces of software from each > source; > - the list of the OS Updates. > What all these windows have in common is that they are dialog boxes > containing a list box and almost nothing else. The margins could be removed. Agree - this would be a nice change. > (In reply to comment #0) > > --- > > Thinking loud: and shouldn’t the “ckecked” mark (« ✔ ») be at the left? > > It could be at left, right, or whatever the designers prefer as long as it > is consistent. But from the pictures in the HIG it seems to me that the > texts in the list should be left-aligned and the check marks should be > right-aligned while in the "Add to folder" popup the app folder names are > centered and the check marks are left-aligned. Allan, what do you think? That's how I'd do it, yes. :)
Created attachment 309254 [details] This is a preview of how it would look like I have this fix almost finished so here is a preview of how it would look like. You are welcome to express your opinion. Honestly I doubt if the new look of the list of sources is what we want despite it's me who proposed this. Otherwise I think it will be fine. It is not clear if we should remove margins, borders, shadows, or all of them but I assume that all because the examples in the HIG document don't show any of them.
(In reply to Rafal Luzynski from comment #5) > ... Honestly I doubt if the new > look of the list of sources is what we want despite it's me who proposed > this. Otherwise I think it will be fine. ... Yes, I agree - I wouldn't change the software sources dialog. The other two look great though!
Created attachment 309316 [details] Screenshot of the installed updates review, new version only
Created attachment 309317 [details] [review] The patch that should fix the problem
Thanks Rafal - I split those up into two separate patches and pushed to master: https://git.gnome.org/browse/gnome-software/commit/?id=5ee44644c702db91dad20b7d572c1a2c9460e48f https://git.gnome.org/browse/gnome-software/commit/?id=222bed061076401026889e82e9d3c3c39eb50569
Created attachment 311420 [details] [review] Remove margins also in the History dialog Sorry but I have to reopen. We have forgotten about the History dialog box. Do you need a screenshot here?
Review of attachment 311420 [details] [review]: Thanks, looks good to me.